Skip to content

Conversation

@Mvrk08
Copy link

@Mvrk08 Mvrk08 commented Jan 19, 2026

Description :

This PR updates the Configuration Guide to include the missing Logging flags section, as requested in parent issue #1074

The following flags have been added to match the server code in config.go:

  • --logger
  • --log-outputs
  • --log-level
  • --log-format
  • --enable-log-rotation
  • --log-rotation-config-json

Related Issue :
Fixes part of #1074

@k8s-ci-robot
Copy link

Hi @Mvrk08. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mvrk08
Copy link
Author

Mvrk08 commented Jan 19, 2026

Hello @ronaldngounou i took the opportunity to make a pr let me know if any more changes are required or not


```nocode
--logger 'zap'
Specify 'zap' for structured logging or 'capnslog'.
Copy link
Member

@ronaldngounou ronaldngounou Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRef says that 'zap' is only supported for structured logging. capnslog is removed in v3.5?

Copy link
Author

@Mvrk08 Mvrk08 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are right .. 'capnslog' is depriciated in v3.5 removed it

Copy link
Member

@ronaldngounou ronaldngounou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please address the comment and sign DCO?

@Mvrk08 Mvrk08 force-pushed the docs-add-logging-flags branch 2 times, most recently from 26c7988 to 76d6f84 Compare January 20, 2026 07:57
@Mvrk08 Mvrk08 closed this Jan 20, 2026
@Mvrk08 Mvrk08 force-pushed the docs-add-logging-flags branch from 76d6f84 to 5d1816a Compare January 20, 2026 08:13
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mvrk08

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Mvrk08
Copy link
Author

Mvrk08 commented Jan 20, 2026

updated pr #1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants