-
Notifications
You must be signed in to change notification settings - Fork 331
docs: add missing logging flags and remove capnslog #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: mrmahi2003 <maahirchauhan20@icloud.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Mvrk08 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Mvrk08. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Just to bring the attention @ronaldngounou i raised a new pr for the same open for the review based on your last remarks in #1104 |
|
Curious why you raised a new PR? Ok I will review. |
|
I encountered some issues fixing the commit history/DCO sign-off on my previous attempt, so I opted to open a fresh PR to ensure the history was clean. |
|
/ok-to-test |
|
@Mvrk08: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Before I start reviewing, could you please address the |
Description :
This PR updates the Configuration Guide to include the missing Logging flags section, as requested in parent issue #1074
The following flags have been added to match the server code in config.go:
--logger
--log-outputs
--log-level
--log-format
--enable-log-rotation
--log-rotation-config-json
Related Issue :
Fixes part of #1074