Skip to content

Conversation

@Mvrk08
Copy link

@Mvrk08 Mvrk08 commented Jan 20, 2026

Description :

This PR updates the Configuration Guide to include the missing Logging flags section, as requested in parent issue #1074

The following flags have been added to match the server code in config.go:

--logger
--log-outputs
--log-level
--log-format
--enable-log-rotation
--log-rotation-config-json

Related Issue :
Fixes part of #1074

Signed-off-by: mrmahi2003 <maahirchauhan20@icloud.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mvrk08
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @Mvrk08. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mvrk08
Copy link
Author

Mvrk08 commented Jan 20, 2026

Just to bring the attention @ronaldngounou i raised a new pr for the same open for the review based on your last remarks in #1104

@ronaldngounou
Copy link
Member

Curious why you raised a new PR? Ok I will review.

@Mvrk08
Copy link
Author

Mvrk08 commented Jan 20, 2026

I encountered some issues fixing the commit history/DCO sign-off on my previous attempt, so I opted to open a fresh PR to ensure the history was clean.

@jberkus jberkus requested a review from ronaldngounou January 21, 2026 00:46
@jberkus
Copy link
Contributor

jberkus commented Jan 21, 2026

/ok-to-test

@k8s-ci-robot
Copy link

@Mvrk08: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-website-lint 94f58d2 link true /test pull-website-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ronaldngounou
Copy link
Member

ronaldngounou commented Jan 21, 2026

Before I start reviewing, could you please address the pull-website-lint failure here? @Mvrk08
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_website/1106/pull-website-lint/2013775133998583808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants