Load rec args#19
Open
prockenschaub wants to merge 6 commits intoeth-mds:mainfrom
Open
Conversation
Note: this currently needs to remove a warning from load_concepts.itm, which may not be desired. Maybe there is another way to prevent unnecessary warnings in the case of additional arguments to load_concepts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #18 for a detailed description of the issues addressed in this PR.
Description of changes
This PR adds the ability to pass arguments to lower-level concepts in recursive concepts. In order to do so, this PR does two things:
collect_dotsto deal with (=ignore) arguments in...that are not concepts. The trade-off is thatcollect_dotscan now only deal with named concepts. However, this does not seem to be a huge problem, since except for two tests (that I changed), all functions pass their concepts with corresponding names.load_concepts.rec_cncpt, it passes...on toload_concepts.itm(viaload_one_concept_helper).Note
load_concepts.itmcurrently checks for elements in...that aren'tkeep_componentsand throws an error if they are present. This behaviour has been removed in this PR to silence unnecessary warnings. However, there might be a good reason for having the warning there and perhaps a different solution must be found.