Closed
Conversation
fix bug whereby deprecated columns was not casted as bool
- New fleetmonitoring option to point toward the API - Refactor validate_http with a more appropriate name
now uses dataclassese
- add CLI support - add dataframe export
- refactor ArgoNVSReferenceTables to inherit from a more general NVScollection class, not limited to Argo tables
- add possibly to pass fs instance to NVS
prepare for ArgoFloat ability to format sensor metadata
Member
Author
|
Hi @SBS-EREHM As suggested, I implemented the possibility to search for more than one model: When meta-data are required for the output with serial numbers or as a dataframe, the metadata fetching is done in parallel with multithreading, which makes this quite rapid. |
keep track of raw data from OEM web-API
- removed relative import - refactor sensor-related dataclass items to utilities
Member
Author
|
This PR won't be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will close #529
Following the last Euro-Argo Meeting, it appears some easy-to-use sensor-related features could be useful to some operators or experts.
This PR provides a new
ArgoSensorandOEMSensorMetaDataclasses to address this.ArgoSensorArgoFloatinstances for each float equipped with a sensor modelArgoSensorReference tables
Access reference tables for SENSOR_MODEL (R27), SENSOR (R25) and SENSOR_MAKER (R26)
Mapping between SENSOR_MODEL (R27) and SENSOR (R25)
Search in SENSOR_MODEL (R27) reference table
Search for all Argo floats equipped with one or more exact sensor model(s)
If the sensor model name is not found in the meta-data base, the error message will provide some hints to help you find the exact name:
Throw a
OptionValueErrorerror message like this:Easily loop through
ArgoFloatinstances for each float equipped with a sensor modelDirectly work with a known and exact sensor model
Use an exact sensor model name to create an instance:
which return some information:
also available in the attributes:
and can be used to list float or/and serial number equipped with this model:
From the command line (CLI)
Get serialized search results from the command-line with
ArgoSensor.cli_searchOEM sensor meta-data
This PR also introduces the
OEMSensorMetaDataclass to work with sensor meta-data from manufacturer and complying to sensor schema from https://github.com/euroargodev/sensor_metadata_json.Currently argopy supports 2 manufacturers API from RBR and Seabird.
Note that the RBR api requires an authentication key (you can contact RBR at argo@rbr-global.com if you do not have an such a key). Argopy will try to get the key from the environment variable
RBR_API_KEYor from the optionrbr_api_key. You can set the key temporarily in your code with:The
OEMSensorMetaDatainstance return a object that has all available metadata properties, notably about pre-deployment calibration.Since this remains in dev. from the manufacturer side, we also provide examples:
PR to-do list