Skip to content

[arista] DARWIN: Mark idprom errors are expected#973

Open
dzarista wants to merge 2 commits intofacebook:mainfrom
dzarista:darwin-eeprom-expected-errors
Open

[arista] DARWIN: Mark idprom errors are expected#973
dzarista wants to merge 2 commits intofacebook:mainfrom
dzarista:darwin-eeprom-expected-errors

Conversation

@dzarista
Copy link
Contributor

@dzarista dzarista commented Mar 3, 2026

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Rackmon and Pem idprom do not support Meta eeprom format, but can still provide useful info through weutil. Therefore, this PR marks them as Expected Errors to avoid test failures.

Test Plan

platform_manager_hw_test passes:

I0303 03:17:00.046983  6538 ExplorationSummary.cpp:49] Explored DARWIN with 0 unexpected errors and 2 expected errors...
I0303 03:17:00.046988  6538 ExplorationSummary.cpp:65] /PEM_SLOT@0/[IDPROM]: Could not fetch contents of IDPROM /sys/bus/i2c/devices/28-0050/eeprom in /PEM_SLOT@0. Invalid EEPROM version : 48
I0303 03:17:00.046994  6538 ExplorationSummary.cpp:65] /RACKMON_SLOT@0/[IDPROM]: Could not fetch contents of IDPROM /sys/bus/i2c/devices/29-0052/eeprom in /RACKMON_SLOT@0. Invalid EEPROM version : 48
...
[==========] Running 8 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 8 tests from PlatformManagerHwTest
[ RUN      ] PlatformManagerHwTest.ExploreAsDeployed
[       OK ] PlatformManagerHwTest.ExploreAsDeployed (30096 ms)
[ RUN      ] PlatformManagerHwTest.ExploreAfterUninstallingKmods
[       OK ] PlatformManagerHwTest.ExploreAfterUninstallingKmods (29769 ms)
[ RUN      ] PlatformManagerHwTest.ExploreAfterUnloadingKmods
[       OK ] PlatformManagerHwTest.ExploreAfterUnloadingKmods (39019 ms)
[ RUN      ] PlatformManagerHwTest.PmExplorationStatusTransitions
[       OK ] PlatformManagerHwTest.PmExplorationStatusTransitions (30188 ms)
[ RUN      ] PlatformManagerHwTest.Symlinks
[       OK ] PlatformManagerHwTest.Symlinks (29522 ms)
[ RUN      ] PlatformManagerHwTest.XcvrCtrlFiles
[       OK ] PlatformManagerHwTest.XcvrCtrlFiles (29149 ms)
[ RUN      ] PlatformManagerHwTest.XcvrIoFiles
[       OK ] PlatformManagerHwTest.XcvrIoFiles (29724 ms)
[ RUN      ] PlatformManagerHwTest.XcvrLedFiles
[       OK ] PlatformManagerHwTest.XcvrLedFiles (29232 ms)
[----------] 8 tests from PlatformManagerHwTest (246702 ms total)

[----------] Global test environment tear-down
[==========] 8 tests from 1 test suite ran. (246702 ms total)
[  PASSED  ] 8 tests.

@meta-cla meta-cla bot added the CLA Signed label Mar 3, 2026
@github-actions github-actions bot added the arista label Mar 3, 2026
@dzarista dzarista marked this pull request as ready for review March 3, 2026 03:24
@dzarista dzarista requested a review from a team as a code owner March 3, 2026 03:24
@meta-codesync
Copy link

meta-codesync bot commented Mar 3, 2026

@joancaneus has imported this pull request. If you are a Meta employee, you can view this in D95007721.

@@ -45,6 +45,13 @@ bool isExpectedError(
}
}

if (*platformConfig.platformName() == "DARWIN" &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add detailed comments on why this exception.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments. Let me know if it is acceptable.

@facebook-github-bot
Copy link
Contributor

@dzarista has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants