[arista] DARWIN: Mark idprom errors are expected#973
Open
dzarista wants to merge 2 commits intofacebook:mainfrom
Open
[arista] DARWIN: Mark idprom errors are expected#973dzarista wants to merge 2 commits intofacebook:mainfrom
dzarista wants to merge 2 commits intofacebook:mainfrom
Conversation
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this in D95007721. |
somasun
requested changes
Mar 4, 2026
| @@ -45,6 +45,13 @@ bool isExpectedError( | |||
| } | |||
| } | |||
|
|
|||
| if (*platformConfig.platformName() == "DARWIN" && | |||
Contributor
There was a problem hiding this comment.
Please add detailed comments on why this exception.
Contributor
Author
There was a problem hiding this comment.
Added comments. Let me know if it is acceptable.
Contributor
|
@dzarista has updated the pull request. You must reimport the pull request before landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Rackmon and Pem idprom do not support Meta eeprom format, but can still provide useful info through weutil. Therefore, this PR marks them as Expected Errors to avoid test failures.
Test Plan
platform_manager_hw_test passes: