Skip to content

[arista] DARWIN: Mark idprom errors are expected #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzarista wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Open

[arista] DARWIN: Mark idprom errors are expected #973

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fd6dac
expected darwin idprom errors
dzarista Mar 2, 2026
1dfa833
Add explanation comments
dzarista Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions fboss/platform/platform_manager/ExplorationErrors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ bool isExpectedError(
}
}

// These idproms do not support Meta EEPROM format, but can still provide
// useful info through WeutilDarwin
if (*platformConfig.platformName() == "DARWIN" &&
Copy link
Contributor

@somasun somasun Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add detailed comments on why this exception.

Copy link
Contributor Author

@dzarista dzarista Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments. Let me know if it is acceptable.

errorType == ExplorationErrorType::IDPROM_READ &&
(devicePath == "/RACKMON_SLOT@0/[IDPROM]" ||
devicePath == "/PEM_SLOT@0/[IDPROM]")) {
return true;
}

return false;
}

Expand Down
Loading