Include entire sam3 package instead of just sam3 and sam3.model#327
Closed
lematt1991 wants to merge 3 commits intomainfrom
Closed
Include entire sam3 package instead of just sam3 and sam3.model#327lematt1991 wants to merge 3 commits intomainfrom
lematt1991 wants to merge 3 commits intomainfrom
Conversation
there are several imports within the `sam3.model` package that reference other packages within `sam3`. This fixes the package structure so that you can `pip install` the package and `import sam3`
meta-cla
bot
added
the
CLA Signed
This way we can include it as package data
haithamkhedr
approved these changes
Dec 10, 2025
|
@lematt1991 has imported this pull request. If you are a Meta employee, you can view this in D88950127. |
|
@lematt1991 merged this pull request in b26a5f3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there are several imports within the
sam3.modelpackage that reference other packages withinsam3other thansam3andsam3.model(for example here). This fixes the package structure so that you canpip installthe package andimport sam3