refactor: switch admin ops from protobuf to binary encoding#9
Merged
vieiralucas merged 1 commit intomainfrom Mar 27, 2026
Merged
refactor: switch admin ops from protobuf to binary encoding#9vieiralucas merged 1 commit intomainfrom
vieiralucas merged 1 commit intomainfrom
Conversation
remove protobufjs dependency and proto files. test helpers now use binary wire format for create_queue and list_queues admin operations instead of protobuf encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protobufjsruntime dependency and all proto files (proto/)createQueueandlistQueuesadmin operationsTest plan
npx tsc --noEmitpasses (verified locally)Summary by cubic
Switched admin operations to a custom binary wire format and removed all protobuf usage. This simplifies tests and removes the
protobufjsruntime.Refactors
proto/and removed protobuf encode/decode paths from tests.CREATE_QUEUEandLIST_QUEUESadmin requests as binary intest/helpers.ts.src/transport.ts.proto/frompackage.jsonfilesso it’s no longer published.Dependencies
protobufjsfrom runtime dependencies.Written for commit ca8f27f. Summary will update on new commits.