Skip to content

refactor: switch admin ops from protobuf to binary encoding#9

Merged
vieiralucas merged 1 commit intomainfrom
refactor/binary-admin-encoding
Mar 27, 2026
Merged

refactor: switch admin ops from protobuf to binary encoding#9
vieiralucas merged 1 commit intomainfrom
refactor/binary-admin-encoding

Conversation

@vieiralucas
Copy link
Copy Markdown
Member

@vieiralucas vieiralucas commented Mar 27, 2026

Summary

  • Remove protobufjs runtime dependency and all proto files (proto/)
  • Update test helpers to use binary wire format for createQueue and listQueues admin operations
  • Remove protobuf loading/encoding/decoding from test infrastructure

Test plan

  • npx tsc --noEmit passes (verified locally)
  • Integration tests pass against a FIBP server with binary admin encoding (PR #153)
  • No protobuf imports remain in the codebase

Summary by cubic

Switched admin operations to a custom binary wire format and removed all protobuf usage. This simplifies tests and removes the protobufjs runtime.

  • Refactors

    • Deleted proto/ and removed protobuf encode/decode paths from tests.
    • Encoded CREATE_QUEUE and LIST_QUEUES admin requests as binary in test/helpers.ts.
    • Marked admin op bodies as binary in src/transport.ts.
    • Removed proto/ from package.json files so it’s no longer published.
  • Dependencies

    • Removed protobufjs from runtime dependencies.

Written for commit ca8f27f. Summary will update on new commits.

remove protobufjs dependency and proto files. test helpers now use binary
wire format for create_queue and list_queues admin operations instead of
protobuf encoding.
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

@vieiralucas vieiralucas merged commit 70d0d96 into main Mar 27, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant