Skip to content

refactor: switch admin ops from protobuf to binary encoding #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vieiralucas merged 1 commit into from
Mar 27, 2026
Merged

refactor: switch admin ops from protobuf to binary encoding #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
"main": "dist/src/index.js",
"types": "dist/src/index.d.ts",
"files": [
"dist/",
"proto/"
"dist/"
],
"scripts": {
"build": "tsc",
Expand All @@ -19,9 +18,7 @@
"test": "vitest run"
},
"license": "AGPL-3.0-or-later",
"dependencies": {
"protobufjs": "^7.5.0"
},
"dependencies": {},
"devDependencies": {
"@types/node": "^22.0.0",
"eslint": "^9.0.0",
Expand Down
197 changes: 0 additions & 197 deletions proto/fila/v1/admin.proto
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions proto/fila/v1/messages.proto
View file
Open in desktop

This file was deleted.

142 changes: 0 additions & 142 deletions proto/fila/v1/service.proto
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
ACK: 0x03,
NACK: 0x04,

// Admin
// Admin (binary body)
CREATE_QUEUE: 0x10,
DELETE_QUEUE: 0x11,
QUEUE_STATS: 0x12,
Expand Down Expand Up @@ -646,7 +646,7 @@

if (op === Op.ERROR) {
const { code, message } = decodeErrorPayload(payload);
const err = new RPCError(code, message);

Check failure on line 649 in src/transport.ts

View workflow job for this annotation

GitHub Actions / test

test/batch.test.ts > Enqueue operations > enqueueMany > enqueues multiple messages in a single RPC 

RPCError: rpc error (code = 65535): protobuf decode error: failed to decode Protobuf message: invalid tag value: 0
 ❯ FibpConnection.dispatchFrame src/transport.ts:649:19
 ❯ FibpConnection.parseFrames src/transport.ts:621:12
 ❯ FibpConnection.onData src/transport.ts:610:10
 ❯ Socket.<anonymous> src/transport.ts:422:47

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 65535, detail: 'protobuf decode error: failed to decode Protobuf message: invalid tag value: 0' }

Check failure on line 649 in src/transport.ts

View workflow job for this annotation

GitHub Actions / test

test/auth.test.ts > TLS + API key auth > mTLS + API key > full flow: enqueue, consume, ack with mTLS + API key 

RPCError: rpc error (code = 65535): protobuf decode error: failed to decode Protobuf message: invalid tag value: 0
 ❯ FibpConnection.dispatchFrame src/transport.ts:649:19
 ❯ FibpConnection.parseFrames src/transport.ts:621:12
 ❯ FibpConnection.onData src/transport.ts:610:10
 ❯ TLSSocket.<anonymous> src/transport.ts:422:47

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 65535, detail: 'protobuf decode error: failed to decode Protobuf message: invalid tag value: 0' }

Check failure on line 649 in src/transport.ts

View workflow job for this annotation

GitHub Actions / test

test/auth.test.ts > TLS + API key auth > mTLS + API key > enqueue succeeds with mTLS + API key 

RPCError: rpc error (code = 65535): protobuf decode error: failed to decode Protobuf message: invalid tag value: 0
 ❯ FibpConnection.dispatchFrame src/transport.ts:649:19
 ❯ FibpConnection.parseFrames src/transport.ts:621:12
 ❯ FibpConnection.onData src/transport.ts:610:10
 ❯ TLSSocket.<anonymous> src/transport.ts:422:47

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 65535, detail: 'protobuf decode error: failed to decode Protobuf message: invalid tag value: 0' }

Check failure on line 649 in src/transport.ts

View workflow job for this annotation

GitHub Actions / test

test/auth.test.ts > TLS + API key auth > TLS (server-only) > fails without CA cert (insecure against TLS server) 

RPCError: rpc error (code = 65535): protobuf decode error: failed to decode Protobuf message: invalid tag value: 0
 ❯ FibpConnection.dispatchFrame src/transport.ts:649:19
 ❯ FibpConnection.parseFrames src/transport.ts:621:12
 ❯ FibpConnection.onData src/transport.ts:610:10
 ❯ TLSSocket.<anonymous> src/transport.ts:422:47

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 65535, detail: 'protobuf decode error: failed to decode Protobuf message: invalid tag value: 0' }

Check failure on line 649 in src/transport.ts

View workflow job for this annotation

GitHub Actions / test

test/auth.test.ts > TLS + API key auth > TLS (server-only) > connects with CA cert (server-TLS) 

RPCError: rpc error (code = 65535): protobuf decode error: failed to decode Protobuf message: invalid tag value: 0
 ❯ FibpConnection.dispatchFrame src/transport.ts:649:19
 ❯ FibpConnection.parseFrames src/transport.ts:621:12
 ❯ FibpConnection.onData src/transport.ts:610:10
 ❯ TLSSocket.<anonymous> src/transport.ts:422:47

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 65535, detail: 'protobuf decode error: failed to decode Protobuf message: invalid tag value: 0' }

Check failure on line 649 in src/transport.ts

View workflow job for this annotation

GitHub Actions / test

test/auth.test.ts > TLS + API key auth > API key authentication (no TLS) > consume works with valid API key 

RPCError: rpc error (code = 65535): protobuf decode error: failed to decode Protobuf message: invalid tag value: 0
 ❯ FibpConnection.dispatchFrame src/transport.ts:649:19
 ❯ FibpConnection.parseFrames src/transport.ts:621:12
 ❯ FibpConnection.onData src/transport.ts:610:10
 ❯ Socket.<anonymous> src/transport.ts:422:47

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 65535, detail: 'protobuf decode error: failed to decode Protobuf message: invalid tag value: 0' }

Check failure on line 649 in src/transport.ts

View workflow job for this annotation

GitHub Actions / test

test/auth.test.ts > TLS + API key auth > API key authentication (no TLS) > enqueue fails with wrong API key 

RPCError: rpc error (code = 65535): protobuf decode error: failed to decode Protobuf message: invalid tag value: 0
 ❯ FibpConnection.dispatchFrame src/transport.ts:649:19
 ❯ FibpConnection.parseFrames src/transport.ts:621:12
 ❯ FibpConnection.onData src/transport.ts:610:10
 ❯ Socket.<anonymous> src/transport.ts:422:47

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 65535, detail: 'protobuf decode error: failed to decode Protobuf message: invalid tag value: 0' }

Check failure on line 649 in src/transport.ts

View workflow job for this annotation

GitHub Actions / test

test/auth.test.ts > TLS + API key auth > API key authentication (no TLS) > enqueue fails without API key (unauthenticated) 

RPCError: rpc error (code = 65535): protobuf decode error: failed to decode Protobuf message: invalid tag value: 0
 ❯ FibpConnection.dispatchFrame src/transport.ts:649:19
 ❯ FibpConnection.parseFrames src/transport.ts:621:12
 ❯ FibpConnection.onData src/transport.ts:610:10
 ❯ Socket.<anonymous> src/transport.ts:422:47

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 65535, detail: 'protobuf decode error: failed to decode Protobuf message: invalid tag value: 0' }

Check failure on line 649 in src/transport.ts

View workflow job for this annotation

GitHub Actions / test

test/auth.test.ts > TLS + API key auth > API key authentication (no TLS) > enqueue succeeds with valid API key 

RPCError: rpc error (code = 65535): protobuf decode error: failed to decode Protobuf message: invalid tag value: 0
 ❯ FibpConnection.dispatchFrame src/transport.ts:649:19
 ❯ FibpConnection.parseFrames src/transport.ts:621:12
 ❯ FibpConnection.onData src/transport.ts:610:10
 ❯ Socket.<anonymous> src/transport.ts:422:47

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 65535, detail: 'protobuf decode error: failed to decode Protobuf message: invalid tag value: 0' }
this.pending.delete(corrId);
entry.reject(err);
return;
Expand Down
Loading
Loading