-
Notifications
You must be signed in to change notification settings - Fork 6
[MAIN] Added pyproject toml setup file for pep517 installation #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShravanTata
wants to merge
9
commits into
farmsim:main
Choose a base branch
from
ShravanTata:pyproject-toml-setup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
After the latest changes, here are some additional things to consider:
|
- Deleted requirements.txt file - Removed install requirements from setup file. They are now part of build requirements in toml - Added numpy to run time dependency
colorama is required by pylog at runtime
Contributor
Author
|
@jarreguit please take a look at the latest commits to address the issues you have mentioned |
- Added numpy max version as there are breaking changes in numpy 2.0 - Removed PyCollada as it is not used in farms_core - Removed Chardet as it is not used in farms_core (Was possibly used in pylog previously) - Removed PyQt5 dependency to allow users to decide manually the backend for matplotlib
Contributor
Author
|
@jarreguit I have addressed few more changes and tested it locally on the pendulum demonstration. Everything seems to work for the simple case (generate sdf, export options, run the simulation, save the data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic pyproject toml file to support latest pip installation for pep517 standards