Skip to content

Conversation

@ShravanTata
Copy link
Contributor

Added basic pyproject toml file to support latest pip installation for pep517 standards

@ShravanTata ShravanTata self-assigned this Dec 20, 2024
@jarreguit
Copy link
Contributor

After the latest changes, here are some additional things to consider:

  • Is the requirements.txt file still necessary? Or does the pyproject.toml replace it?
  • Numpy should probably be part of the dependencies, not just the build-system requirements. I am not sure for Cython, I would expect it only needs to be used in the build-system as currently defined.

- Deleted requirements.txt file
- Removed install requirements from setup file. They are now part of build requirements
  in toml
- Added numpy to run time dependency
colorama is required by pylog at runtime
@ShravanTata
Copy link
Contributor Author

@jarreguit please take a look at the latest commits to address the issues you have mentioned

@ShravanTata ShravanTata requested review from jarreguit and removed request for jarreguit June 6, 2025 15:06
- Added numpy max version as there are breaking changes in numpy 2.0
- Removed PyCollada as it is not used in farms_core
- Removed Chardet as it is not used in farms_core (Was possibly used in pylog
 previously)
- Removed PyQt5 dependency to allow users to decide manually the backend for matplotlib
@ShravanTata
Copy link
Contributor Author

@jarreguit I have addressed few more changes and tested it locally on the pendulum demonstration. Everything seems to work for the simple case (generate sdf, export options, run the simulation, save the data)

@ShravanTata ShravanTata linked an issue Jul 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to pyproject.toml build file system

2 participants