fix(ff-effect): preserve OUTPUT generic in generateText wrapper#67
Merged
fix(ff-effect): preserve OUTPUT generic in generateText wrapper#67
Conversation
Thread TOOLS and OUTPUT type parameters through so the return type reflects the actual output schema instead of resolving to `any`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOOLSandOUTPUTgeneric parameters to thegenerateTextwrappertypeof Ai.generateText<TOOLS, OUTPUT>) to thread generics through params and return typeresult.outputnow infers the correct schema type (e.g.{ message: string }) instead ofanyTest plan
outputschema togenerateTextand verifyresult.outputis typed correctly