Skip to content

fix(ff-effect): preserve OUTPUT generic in generateText wrapper #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdarian merged 2 commits into from
Apr 4, 2026
Merged

fix(ff-effect): preserve OUTPUT generic in generateText wrapper #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
510d430
fix: preserve OUTPUT generic in generateText wrapper
fdarian Apr 4, 2026
8498ce9
docs: changeset
fdarian Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/generate-text-output-type.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ff-effect": patch
---

fix: preserve `OUTPUT` generic in `generateText` wrapper so `result.output` is properly typed instead of resolving to `any`
19 changes: 12 additions & 7 deletions packages/effect/src/for/ai/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,21 @@ type EffectifyCallbacks<T, Keys extends string, R> = Omit<T, Keys & keyof T> & {
: T[K];
};

type GenerateTextOriginalParams = Parameters<typeof Ai.generateText>[0];
type GenerateTextReturn = Awaited<ReturnType<typeof Ai.generateText>>;

export function generateText<R = never>(
export function generateText<
TOOLS extends Ai.ToolSet = Ai.ToolSet,
OUTPUT extends Ai.Output.Output = Ai.Output.Output<string, string>,
R = never,
>(
params: EffectifyCallbacks<
GenerateTextOriginalParams,
Parameters<typeof Ai.generateText<TOOLS, OUTPUT>>[0],
GenerateTextCallbackKeys,
R
>,
): Effect.Effect<GenerateTextReturn, AiError, R> {
): Effect.Effect<
Awaited<ReturnType<typeof Ai.generateText<TOOLS, OUTPUT>>>,
AiError,
R
> {
return Effect.gen(function* () {
const runPromise = yield* FiberSet.makeRuntimePromise<R>();

Expand All @@ -75,7 +80,7 @@ export function generateText<R = never>(
runPromise,
params.experimental_onToolCallFinish,
),
} as GenerateTextOriginalParams;
} as Parameters<typeof Ai.generateText<TOOLS, OUTPUT>>[0];

return yield* Effect.tryPromise({
try: () => Ai.generateText(originalParams),
Expand Down
Loading