Add more environment variables to detect cloud environments

[kotl]

Description

Add more environment variables to detect cloud environments
(firebase CLI does not automatically apply --nolocalhost when running in Cloud environment)

Scenarios Tested

inside Cloud shell -> https://shell.cloud.google.com/

Sample Commands

export CLOUD_SHELL=true
firebase auth login

unset CLOUD_SHELL
firebase auth login

[gemini-code-assist]

Summary of Changes

Hello @kotl, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase CLI's capability to automatically detect when it is operating within various cloud environments. By incorporating checks for additional environment variables, the CLI will now more reliably identify cloud-based execution contexts, ensuring that it applies necessary behaviors, such as --nolocalhost, without requiring manual configuration. This change addresses a scenario where the Firebase CLI previously failed to automatically apply --nolocalhost when running in certain cloud environments.

Highlights

• Cloud Environment Detection: The isCloudEnvironment utility function has been updated to recognize additional environment variables, specifically CLOUD_SHELL and GOOGLE_CLOUD_SHELL, to improve detection of cloud-based execution environments for the Firebase CLI.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds environment variables to detect cloud environments, which is a useful enhancement. The implementation is straightforward. I have one suggestion to improve the maintainability of the code.

[gemini-code-assist]

For better maintainability and readability, you could define the environment variable names in an array and use the some method directly. This makes it easier to add or remove variables in the future. I've also added an explicit return type for clarity.

Suggested change

	export function isCloudEnvironment() {
	return !!process.env.CODESPACES || !!process.env.GOOGLE_CLOUD_WORKSTATIONS;
	return (
	!!process.env.CODESPACES ||
	!!process.env.GOOGLE_CLOUD_WORKSTATIONS ||
	!!process.env.CLOUD_SHELL ||
	!!process.env.GOOGLE_CLOUD_SHELL
	);
	}
	export function isCloudEnvironment(): boolean {
	return [
	"CODESPACES",
	"GOOGLE_CLOUD_WORKSTATIONS",
	"CLOUD_SHELL",
	"GOOGLE_CLOUD_SHELL",
	].some((envVar) => !!process.env[envVar]);
	}

[LifeLoggerAI]

[joehan]

Thanks!