Skip to content

Add more environment variables to detect cloud environments #9408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2025
Merged

Add more environment variables to detect cloud environments #9408

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa199f2
Add more environment variables to detect cloud environments
kotl Oct 29, 2025
8b9da94
Merge branch 'master' into master
kotl Oct 30, 2025
6a1deba
Merge branch 'master' into master
kotl Oct 30, 2025
da53ccf
Merge branch 'master' into master
kotl Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,12 @@ export function datetimeString(d: Date): string {
* Indicates whether the end-user is running the CLI from a cloud-based environment.
*/
export function isCloudEnvironment() {
return !!process.env.CODESPACES || !!process.env.GOOGLE_CLOUD_WORKSTATIONS;
return (
!!process.env.CODESPACES ||
!!process.env.GOOGLE_CLOUD_WORKSTATIONS ||
!!process.env.CLOUD_SHELL ||
!!process.env.GOOGLE_CLOUD_SHELL
);
}
Comment on lines 568 to 575
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and readability, you could define the environment variable names in an array and use the some method directly. This makes it easier to add or remove variables in the future. I've also added an explicit return type for clarity.

Suggested change
export function isCloudEnvironment() {
return !!process.env.CODESPACES || !!process.env.GOOGLE_CLOUD_WORKSTATIONS;
return (
!!process.env.CODESPACES ||
!!process.env.GOOGLE_CLOUD_WORKSTATIONS ||
!!process.env.CLOUD_SHELL ||
!!process.env.GOOGLE_CLOUD_SHELL
);
}
export function isCloudEnvironment(): boolean {
return [
"CODESPACES",
"GOOGLE_CLOUD_WORKSTATIONS",
"CLOUD_SHELL",
"GOOGLE_CLOUD_SHELL",
].some((envVar) => !!process.env[envVar]);
}


/**
Expand Down
Loading