Added prepush typechecking

[jpremo]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @jpremo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to the development workflow by integrating automated typechecking into the Git pre-push process. By leveraging Husky, the system will now prevent code with type errors from being pushed, thereby enhancing code quality and reducing potential issues in the main codebase.

Highlights

• Pre-push Hook: A new pre-push Git hook has been implemented using Husky to automatically run npm run typecheck before any code is pushed to the remote repository.
• Dependency Addition: The husky package, version 9.1.7, has been added as a development dependency to enable the Git hooks.
• Script Configuration: A prepare script has been added to package.json to ensure Husky is properly installed and configured when dependencies are installed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a pre-push hook using husky to run type-checking, which is a great step towards improving code quality. My review includes a critical fix for the husky hook script to ensure it runs correctly, and a suggestion to move the husky package to devDependencies as it's a development-only tool. With these changes, the PR will be in excellent shape.

[gemini-code-assist]

The pre-push hook script is missing the necessary shebang and command to source husky's environment. Without these, the hook may not execute correctly or reliably across different environments. Please update the script to follow the standard husky v9 format.

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npm run typecheck

[gemini-code-assist]

The husky package is a development tool and is not required for the application to run in production. It's best practice to list such packages under devDependencies to keep the production dependencies clean and minimal. Please move husky from dependencies to devDependencies. You will need to run npm install again to update the package-lock.json file.

References

1. Development-only tools and libraries should be listed in devDependencies, not dependencies, to avoid including them in production builds.