Skip to content

Added prepush typechecking #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpremo wants to merge 1 commit into
base: develop
Choose a base branch
from
+20 −1
Open

Added prepush typechecking #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .husky/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
npm run typecheck
Copy link

@gemini-code-assist gemini-code-assist bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The pre-push hook script is missing the necessary shebang and command to source husky's environment. Without these, the hook may not execute correctly or reliably across different environments. Please update the script to follow the standard husky v9 format.

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npm run typecheck

16 changes: 16 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"postinstall": "patch-package",
"deploy:model": "tsx cli/deploy.ts model",
"deploy:public": "tsx cli/deploy.ts public static",
"deploy": "npm-run-all build deploy:*"
"deploy": "npm-run-all build deploy:*",
"prepare": "husky"
},
"dependencies": {
"@csstools/normalize.css": "^12.1.1",
Expand All @@ -24,6 +25,7 @@
"class-variance-authority": "^0.7.1",
"clsx": "^2.1.1",
"epicenter-libs": "^3.32.0",
"husky": "^9.1.7",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The husky package is a development tool and is not required for the application to run in production. It's best practice to list such packages under devDependencies to keep the production dependencies clean and minimal. Please move husky from dependencies to devDependencies. You will need to run npm install again to update the package-lock.json file.

References
  1. Development-only tools and libraries should be listed in devDependencies, not dependencies, to avoid including them in production builds.

"i18next": "^25.6.0",
"jotai": "^2.15.0",
"lucide-react": "^0.548.0",
Expand Down