Fix flaky test_multiple_clients_subscription in CI #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sanity
force-pushed
the
fix-flaky-test-timeouts
branch
3 times, most recently
from
dd78059 to
c73437c
Compare
…ents_subscription The test was failing in CI when Client 3 (on Node B) tries to get a contract that was put on Node A. Testing shows this cross-node propagation takes ~5.5 seconds locally but can take longer in CI environments. Increased timeouts from 30s to 60s for: - Client 3's GET request after cross-node propagation - Client 3's subscribe operation Added diagnostic logging that shows Client 3's GET takes 5.527s locally, confirming the propagation works but needs more time in slower environments. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
sanity
force-pushed
the
fix-flaky-test-timeouts
branch
from
833d5e6 to
54ba135
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the flaky
test_multiple_clients_subscriptiontest that was timing out in CI when Client 3 attempts to get a contract from Node B that was put on Node A.Problem
The test was failing with:
Root Cause
Testing revealed that cross-node contract propagation (Node A → Gateway → Node B) takes ~5.5 seconds locally. In slower CI environments, this can exceed the 30-second timeout when combined with other test operations.
Solution
Testing
🤖 Generated with Claude Code