ref(server): Return status code 413 if envelope is rejected due to size limits #5474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/413-on-too-large
branch
from
c7b5b48 to
06a3e6d
Compare
jjbayer
approved these changes
Dec 12, 2025
| - Increases log size limits to better support log drains. ([#5441](https://github.com/getsentry/relay/pull/5441)) | ||
| - Add functionality to process and store span attachments. ([#5423](https://github.com/getsentry/relay/pull/5423), [#5363](https://github.com/getsentry/relay/pull/5363)) | ||
| - Apply existing cookie rules to `http.request.header.cookie.<key>` fields. ([#5456](https://github.com/getsentry/relay/pull/5456)) | ||
| - Return status code `413` if a request is rejected due to size limits. ([#5474](https://github.com/getsentry/relay/pull/5474)) |
Member
There was a problem hiding this comment.
We should put this under **Breaking Changes** even if all our own SDKs already handle 413s correctly. There might be custom clients out there that don't.
| // now executed asynchronously in `EnvelopeProcessor`. | ||
| (StatusCode::FORBIDDEN, body).into_response() | ||
| } | ||
| BadStoreRequest::Overflow(_) => (StatusCode::PAYLOAD_TOO_LARGE, body).into_response(), |
Member
There was a problem hiding this comment.
So if I understand the DACI and docs correctly, Relay will keep emitting outcomes for this, but the SDK will stop doing so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a discussion with the SDK team(s). SDKs are currently emitting client reports when Relay rejects an item if it is too large, but Relay also emits an outcome in that case. If SDKs can differentiate the item size limit, we can stop emitting these outcomes (for stats) twice.
Discussion point: Is this a breaking change, ideally SDKs only special case 429. DACI: https://www.notion.so/sentry/DACI-Relay-Returns-413-for-too-large-envelopes-2c68b10e4b5d8034be83e524c855e73d
TODO: This still needs an integration test or multiple