Skip to content

ref(server): Return status code 413 if envelope is rejected due to size limits #5474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dav1dde wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

ref(server): Return status code 413 if envelope is rejected due to size limits #5474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Increases log size limits to better support log drains. ([#5441](https://github.com/getsentry/relay/pull/5441))
- Add functionality to process and store span attachments. ([#5423](https://github.com/getsentry/relay/pull/5423), [#5363](https://github.com/getsentry/relay/pull/5363))
- Apply existing cookie rules to `http.request.header.cookie.<key>` fields. ([#5456](https://github.com/getsentry/relay/pull/5456))
- Return status code `413` if a request is rejected due to size limits. ([#5474](https://github.com/getsentry/relay/pull/5474))
Copy link
Member

@jjbayer jjbayer Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put this under **Breaking Changes** even if all our own SDKs already handle 413s correctly. There might be custom clients out there that don't.

- Add functionality to process and store trace attachments. ([#5457](https://github.com/getsentry/relay/pull/5457))

**Bug Fixes**:
Expand Down
1 change: 1 addition & 0 deletions relay-server/src/endpoints/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ impl IntoResponse for BadStoreRequest {
// now executed asynchronously in `EnvelopeProcessor`.
(StatusCode::FORBIDDEN, body).into_response()
}
BadStoreRequest::Overflow(_) => (StatusCode::PAYLOAD_TOO_LARGE, body).into_response(),
Copy link
Member

@jjbayer jjbayer Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand the DACI and docs correctly, Relay will keep emitting outcomes for this, but the SDK will stop doing so?

_ => {
// In all other cases, we indicate a generic bad request to the client and render
// the cause. This was likely the client's fault.
Expand Down
Loading