Skip to content

Conversation

iw4p
Copy link

@iw4p iw4p commented Oct 3, 2025

Add helper function _call_complete_prompt() to eliminate repeated complete_prompt() calls with identical parameters across all test functions. This reduces test code by ~25% while maintaining the same test coverage.

Changes:

  • Add _call_complete_prompt(temperature=0.0) helper function
  • Replace 5 duplicate complete_prompt() calls with helper
  • Reduce file from 104 to 79 lines (24% reduction)

This refactoring improves code maintainability by centralizing the common test parameters in a single helper function. Previously, each test function contained identical complete_prompt() calls with the same parameters, leading to code duplication and making future parameter changes error-prone. The helper function eliminates this duplication while preserving all existing test behavior and coverage.

Benefits:
Reduces code duplication by 24% (104 → 79 lines)
Improves maintainability - parameter changes only need to be made once
Maintains identical test behavior and coverage
Follows DRY (Don't Repeat Yourself) principle
No functional changes to test logic

Files changed:

  • tests/sentry/llm/test_preview.py - Added helper function and refactored all test functions

Testing:

  • All existing tests pass with no modifications to test logic

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Add helper function _call_complete_prompt() to eliminate repeated complete_prompt() calls with identical parameters across all test functions. This reduces test code by ~25% while maintaining the same test coverage.

Changes:
- Add _call_complete_prompt(temperature=0.0) helper function
- Replace 5 duplicate complete_prompt() calls with helper
- Reduce file from 104 to 79 lines (24% reduction)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant