refactor(tests): Reduce code duplication in LLM tests #100928
+17
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helper function _call_complete_prompt() to eliminate repeated complete_prompt() calls with identical parameters across all test functions. This reduces test code by ~25% while maintaining the same test coverage.
Changes:
This refactoring improves code maintainability by centralizing the common test parameters in a single helper function. Previously, each test function contained identical
complete_prompt()
calls with the same parameters, leading to code duplication and making future parameter changes error-prone. The helper function eliminates this duplication while preserving all existing test behavior and coverage.Benefits:
Reduces code duplication by 24% (104 → 79 lines)
Improves maintainability - parameter changes only need to be made once
Maintains identical test behavior and coverage
Follows DRY (Don't Repeat Yourself) principle
No functional changes to test logic
Files changed:
tests/sentry/llm/test_preview.py
- Added helper function and refactored all test functionsTesting:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.