Skip to content

refactor(tests): Reduce code duplication in LLM tests #100928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(tests): Reduce code duplication in LLM tests #100928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 17 additions & 42 deletions tests/sentry/llm/test_preview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@
from sentry.llm.usecases import LLMUseCase, complete_prompt


def _call_complete_prompt(temperature=0.0):
"""Helper function to call complete_prompt with common test parameters."""
return complete_prompt(
usecase=LLMUseCase.EXAMPLE,
prompt="prompt here",
message="message here",
temperature=temperature,
max_output_tokens=1024,
)


def test_complete_prompt(set_sentry_option) -> None:
with (
set_sentry_option("llm.provider.options", {"preview": {"models": ["stub-1.0"]}}),
Expand All @@ -12,13 +23,7 @@ def test_complete_prompt(set_sentry_option) -> None:
{"example": {"provider": "preview", "options": {"model": "stub-1.0"}}},
),
):
res = complete_prompt(
usecase=LLMUseCase.EXAMPLE,
prompt="prompt here",
message="message here",
temperature=0.0,
max_output_tokens=1024,
)
res = _call_complete_prompt()

assert res == ""

Expand All @@ -32,13 +37,7 @@ def test_invalid_usecase_config(set_sentry_option) -> None:
),
):
with pytest.raises(InvalidUsecaseError):
complete_prompt(
usecase=LLMUseCase.EXAMPLE,
prompt="prompt here",
message="message here",
temperature=0.0,
max_output_tokens=1024,
)
_call_complete_prompt()


def test_invalid_provider_config(set_sentry_option) -> None:
Expand All @@ -50,13 +49,7 @@ def test_invalid_provider_config(set_sentry_option) -> None:
),
):
with pytest.raises(InvalidProviderError):
complete_prompt(
usecase=LLMUseCase.EXAMPLE,
prompt="prompt here",
message="message here",
temperature=0.0,
max_output_tokens=1024,
)
_call_complete_prompt()


def test_invalid_model(set_sentry_option) -> None:
Expand All @@ -68,13 +61,7 @@ def test_invalid_model(set_sentry_option) -> None:
),
):
with pytest.raises(InvalidModelError):
complete_prompt(
usecase=LLMUseCase.EXAMPLE,
prompt="prompt here",
message="message here",
temperature=0.0,
max_output_tokens=1024,
)
_call_complete_prompt()


def test_invalid_temperature(set_sentry_option) -> None:
Expand All @@ -86,18 +73,6 @@ def test_invalid_temperature(set_sentry_option) -> None:
),
):
with pytest.raises(ValueError):
complete_prompt(
usecase=LLMUseCase.EXAMPLE,
prompt="prompt here",
message="message here",
temperature=-1,
max_output_tokens=1024,
)
_call_complete_prompt(temperature=-1)
with pytest.raises(ValueError):
complete_prompt(
usecase=LLMUseCase.EXAMPLE,
prompt="prompt here",
message="message here",
temperature=2,
max_output_tokens=1024,
)
_call_complete_prompt(temperature=2)
Loading