Skip to content

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Oct 6, 2025

follow up to

which accidentally introduced duplicate tabs, as there are more places that weren’t accessible to me that also rendered the <FrontendHeader> and should’ve been removed in that PR.

fixes:
Screenshot 2025-10-06 at 09 41 13

@TkDodo TkDodo marked this pull request as ready for review October 6, 2025 07:45
@TkDodo TkDodo requested review from a team as code owners October 6, 2025 07:45
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 6, 2025
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #100948   +/-   ##
========================================
  Coverage   81.14%    81.14%           
========================================
  Files        8630      8630           
  Lines      382756    382756           
  Branches    24053     24053           
========================================
  Hits       310600    310600           
  Misses      71824     71824           
  Partials      332       332           

that is now handled by the layout, so we can't assert that in a test anymore
@TkDodo TkDodo merged commit 4b4a6b0 into master Oct 6, 2025
47 checks passed
@TkDodo TkDodo deleted the tkdodo/fix/duplicate-frontend-tabs branch October 6, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants