feat(integrations): Support extracting the file revision/hash from symcache#104750
feat(integrations): Support extracting the file revision/hash from symcache#104750
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104750 +/- ##
===========================================
- Coverage 80.60% 80.48% -0.12%
===========================================
Files 9356 9351 -5
Lines 403999 401712 -2287
Branches 25813 25813
===========================================
- Hits 325638 323337 -2301
- Misses 77919 77933 +14
Partials 442 442 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
5e9d65f to
58a1da0
Compare
cathteng
left a comment
There was a problem hiding this comment.
I can't comment on the accuracy but it just looks like we're adding #{revision} to urls if a revision exists
|
|
||
| return False | ||
|
|
||
| def get_stacktrace_link( |
There was a problem hiding this comment.
The default get_stacktrace_link implementation has some tags being set on the scope. Are these applicable here?
Example
Not sure if it's strictly necessary in this PR but we'd also eventually want to have SLOs for this function because the parent implementation is being overwritten
sentry/src/sentry/integrations/source_code_management/repository.py
Lines 195 to 197 in b8f35e0
| function: str | None = None | ||
| package: str | None = None | ||
| module: str | None = None | ||
| revision: str | None = None |
There was a problem hiding this comment.
Will the frame dictionaries contain revision in order for this to work?
sentry/src/sentry/integrations/utils/commit_context.py
Lines 60 to 62 in b8f35e0
Depends on: getsentry/symbolic#943