Skip to content

feat(integrations): Support extracting the file revision/hash from symcache#104750

Open
mujacica wants to merge 2 commits intomasterfrom
feat/revision-from-symcache
Open

feat(integrations): Support extracting the file revision/hash from symcache#104750
mujacica wants to merge 2 commits intomasterfrom
feat/revision-from-symcache

Conversation

@mujacica
Copy link
Contributor

@mujacica mujacica commented Dec 11, 2025

  • Support extracting the file revision/hash from symcache

Depends on: getsentry/symbolic#943

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104750      +/-   ##
===========================================
- Coverage   80.60%    80.48%   -0.12%     
===========================================
  Files        9356      9351       -5     
  Lines      403999    401712    -2287     
  Branches    25813     25813              
===========================================
- Hits       325638    323337    -2301     
- Misses      77919     77933      +14     
  Partials      442       442              

@getsantry
Copy link
Contributor

getsantry bot commented Jan 2, 2026

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jan 2, 2026
@mujacica mujacica marked this pull request as ready for review January 7, 2026 08:18
@mujacica mujacica requested review from a team as code owners January 7, 2026 08:18
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the accuracy but it just looks like we're adding #{revision} to urls if a revision exists


return False

def get_stacktrace_link(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default get_stacktrace_link implementation has some tags being set on the scope. Are these applicable here?

Example

scope.set_tag("stacktrace_link.tried_version", False)

Not sure if it's strictly necessary in this PR but we'd also eventually want to have SLOs for this function because the parent implementation is being overwritten

with self.record_event(
SCMIntegrationInteractionType.GET_STACKTRACE_LINK
).capture() as lifecycle:

function: str | None = None
package: str | None = None
module: str | None = None
revision: str | None = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the frame dictionaries contain revision in order for this to work?

EventFrame.from_dict(frame)
for frame in frames
if frame.get("lineno") is not None and frame.get("in_app")

Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files owned by Ingest LGTM.

@getsantry getsantry bot removed the Stale label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants