feat(integrations): Support extracting the file revision/hash from symcache

src/sentry/integrations/perforce/client.py

@@ -507,6 +507,11 @@ def get_blame_for_files(
                     # already part of the depot path we get from stacktrace (SourceLineInfo)
                     depot_path = self.build_depot_path(file.repo, file.path, None)
 
+                    # If revision is available from symcache, append it to depot path
+                    # This allows us to get the exact changelist that created this revision
+                    if file.revision:
+                        depot_path = f"{depot_path}#{file.revision}"
+
                     # Use p4 changes -m 1 -l to get most recent change for this file
                     # -m 1: limit to 1 result (most recent)
                     # -l: include full changelist description
@@ -554,6 +559,7 @@ def get_blame_for_files(
                             ref=file.ref,
                             repo=file.repo,
                             code_mapping=file.code_mapping,
+                            revision=file.revision,
                             commit=commit,
                         )
                         blames.append(blame_info)

src/sentry/integrations/perforce/integration.py

@@ -210,6 +210,22 @@ def source_url_matches(self, url: str) -> bool:
 
         return False
 
+    def get_stacktrace_link(
+        self, repo: Repository, filepath: str, default: str, version: str | None
+    ) -> str | None:
+        """
+        Get stacktrace link for Perforce file.
+
+        For Perforce, version represents the file revision number.
+        We append it to the filepath using Perforce's #revision syntax.
+        """
+        # Append version/revision to filepath if provided
+        if version:
+            filepath = f"{filepath}#{version}"
+
+        # Use parent implementation with the modified filepath
+        return self.check_file(repo, filepath, default)
+
     def check_file(self, repo: Repository, filepath: str, branch: str | None = None) -> str | None:
         """
         Check if a file exists in the Perforce depot and return the URL.

src/sentry/integrations/source_code_management/commit_context.py

@@ -84,6 +84,7 @@ class SourceLineInfo:
     ref: str
     repo: Repository
     code_mapping: RepositoryProjectPathConfig
+    revision: str | None
 
 
 @dataclass

src/sentry/integrations/utils/commit_context.py

@@ -254,6 +254,7 @@ def _generate_integration_to_files_mapping(
                     ref=code_mapping.default_branch or "master",
                     repo=code_mapping.repository,
                     code_mapping=code_mapping,
+                    revision=frame.revision,
                 )
             )
             break

src/sentry/integrations/utils/stacktrace_link.py

@@ -103,7 +103,9 @@ def get_stacktrace_config(
             result["error"] = "stack_root_mismatch"
             continue
 
-        outcome = get_link(config, src_path, ctx["commit_id"])
+        # Use commit_id if available, otherwise fall back to revision (from symcache)
+        version = ctx["commit_id"] if ctx["commit_id"] else ctx.get("revision")
+        outcome = get_link(config, src_path, version)
         result["iteration_count"] += 1
 
         result["current_config"] = {

src/sentry/interfaces/stacktrace.py

@@ -161,6 +161,7 @@ def to_python(cls, data, **kwargs):
             "platform",
             "post_context",
             "pre_context",
+            "revision",
             "source_link",
             "symbol",
             "symbol_addr",
@@ -198,6 +199,7 @@ def to_json(self):
                 "lineno": self.lineno,
                 "colno": self.colno,
                 "lock": self.lock,
+                "revision": self.revision or None,
                 "source_link": self.source_link or None,
             }
         )
@@ -233,6 +235,7 @@ def get_api_context(self, is_public=False, platform=None, pad_addr=None):
             "trust": self.trust,
             "errors": self.errors,
             "lock": self.lock,
+            "revision": self.revision,
             "sourceLink": source_link,
         }
 
@@ -291,6 +294,7 @@ def get_meta_context(self, meta, is_public=False, platform=None):
             "trust": meta.get("trust"),
             "errors": meta.get("errors"),
             "lock": meta.get("lock"),
+            "revision": meta.get("revision"),
             "sourceLink": meta.get("source_link"),
         }
 

src/sentry/issues/endpoints/project_stacktrace_link.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import logging
-from typing import TypedDict
+from typing import NotRequired, TypedDict
 
 from django.http import QueryDict
 from rest_framework.request import Request
@@ -36,6 +36,7 @@ class StacktraceLinkContext(TypedDict):
     module: str | None
     package: str | None
     sdk_name: str | None
+    revision: NotRequired[str | None]
 
 
 def generate_context(parameters: QueryDict) -> StacktraceLinkContext:
@@ -51,6 +52,7 @@ def generate_context(parameters: QueryDict) -> StacktraceLinkContext:
         "package": parameters.get("package"),
         "line_no": parameters.get("lineNo"),
         "group_id": parameters.get("groupId"),
+        "revision": parameters.get("revision"),
     }
 
 

src/sentry/lang/native/processing.py

@@ -119,6 +119,8 @@ def _merge_frame(new_frame, symbolicated, platform="native"):
         new_frame["post_context"] = symbolicated["post_context"]
     if symbolicated.get("source_link"):
         new_frame["source_link"] = symbolicated["source_link"]
+    if symbolicated.get("revision"):
+        new_frame["revision"] = symbolicated["revision"]
 
     addr_mode = symbolicated.get("addr_mode")
     if addr_mode is None:

src/sentry/utils/event_frames.py

@@ -22,6 +22,7 @@ class EventFrame:
     function: str | None = None
     package: str | None = None
     module: str | None = None
+    revision: str | None = None
 
     @classmethod
     def from_dict(cls, data: Mapping[str, Any]) -> EventFrame:

tests/sentry/event_manager/interfaces/snapshots/test_exception/test_basic.pysnap

@@ -28,6 +28,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null
@@ -61,6 +62,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null

tests/sentry/event_manager/interfaces/snapshots/test_exception/test_context_with_mechanism.pysnap

@@ -31,6 +31,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null

tests/sentry/event_manager/interfaces/snapshots/test_exception/test_context_with_mixed_frames.pysnap

@@ -28,6 +28,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null
@@ -61,6 +62,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null

tests/sentry/event_manager/interfaces/snapshots/test_exception/test_context_with_only_app_frames.pysnap

@@ -28,6 +28,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null
@@ -61,6 +62,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null

tests/sentry/event_manager/interfaces/snapshots/test_exception/test_context_with_only_system_frames.pysnap

@@ -28,6 +28,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null
@@ -61,6 +62,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null

tests/sentry/event_manager/interfaces/snapshots/test_exception/test_context_with_raw_values.pysnap

@@ -25,6 +25,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null
@@ -51,6 +52,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null

tests/sentry/event_manager/interfaces/snapshots/test_exception/test_context_with_symbols.pysnap

@@ -28,6 +28,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: Class.myfunc
         symbolAddr: null

tests/sentry/event_manager/interfaces/snapshots/test_exception/test_context_with_two_exceptions_having_mechanism.pysnap

@@ -33,6 +33,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null
@@ -71,6 +72,7 @@ get_api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null

tests/sentry/event_manager/interfaces/snapshots/test_threads/test_basics.pysnap

@@ -1,5 +1,5 @@
 ---
-source: tests/sentry/event_manager/interfaces/test_threads.py
+source: tests/sentry/event_manager/interfaces/test_threads.py::test_basics
 ---
 api_context:
   values:
@@ -30,6 +30,7 @@ api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null
@@ -54,6 +55,7 @@ api_context:
         package: null
         platform: null
         rawFunction: null
+        revision: null
         sourceLink: null
         symbol: null
         symbolAddr: null