core: move links under components/core #94600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94600 +/- ##
===========================================
+ Coverage 61.39% 81.76% +20.37%
===========================================
Files 10436 10408 -28
Lines 603387 602136 -1251
Branches 23491 23420 -71
===========================================
+ Hits 370460 492363 +121903
+ Misses 232561 109021 -123540
- Partials 366 752 +386 |
|
Requires #94628 to unblock CI |
Fix the last remaining issue of linkStyle export which is blocking CI on #94600 **Before**  **After** 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move link component under components/core and use a named export like the rest of the core components.
I will followup with the change to bring ExternalLink under the same folder in a separate PR and likely remove the Anchor element, that way the links become just Link or ExternalLink.