gsapp: remove use of linkStyles #94628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -104,9 +104,13 @@ class PowerFeatureHovercard extends Component<Props> { | |||
| ? t('Better With %s Plan', planName) | |||
| : t('Requires %s Plan', planName)} | |||
| </div> | |||
| <LearnMoreLink onClick={this.handleClick} data-test-id="power-learn-more"> | |||
| <ExternalLink | |||
There was a problem hiding this comment.
Should it be LinkButton with priority link lol
There was a problem hiding this comment.
Yeah, but it also falls into the problem that our links allow empty hrefs (both via props and implicitly via disabled field). I'm going to see if we can just make this use a button, it looks like we might want a stronger CTA anyways.
There was a problem hiding this comment.
I've went ahead and changed this to use a button + the lightning icon
natemoo-re
approved these changes
Jun 30, 2025
evanpurkhiser
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the last remaining issue of linkStyle export which is blocking CI on #94600
Before
After