fix(symcache): Allow -2 as a tombstone address #1789
+33
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bumps `symbolic` to 12.16.3 to get access to getsentry/symbolic#937, which fixes symcache generation for some DWARF files. The symcache version is compatibly bumped to 11.
tobias-wilfert
approved these changes
Sep 18, 2025
Dav1dde
requested changes
Sep 18, 2025
Dav1dde
approved these changes
Sep 18, 2025
| checksum = "dfbe277e56a376000877090da837660b4427aad530e3028d44e0bffe4f89a1c1" | ||
| dependencies = [ | ||
| "gimli", | ||
| "gimli 0.31.1", |
There was a problem hiding this comment.
That's unfortunate, but hopefully not an issue?
There was a problem hiding this comment.
Shouldn't be. The other version is via the sentry SDK.
|
Holding off on merging and deploying this until I get back from vacation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps
symbolicto 12.16.3 to get access togetsentry/symbolic#937, which fixes symcache generation for some DWARF files.
The symcache version is compatibly bumped to 11.
ref: INGEST-451.