Skip to content

fix(symcache): Allow -2 as a tombstone address #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2025
+33 −23
Merged

fix(symcache): Allow -2 as a tombstone address #1789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8926e74
fix(symcache): Allow -2 as a tombstone address
loewenheim Sep 18, 2025
5843e0f
Cargo.lock
loewenheim Sep 18, 2025
eeede59
lint
loewenheim Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 26 additions & 20 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ serde_yaml = "0.9.14"
sha-1 = "0.10.0"
sha2 = "0.10.6"
sketches-ddsketch = "0.3.0"
symbolic = "12.16.2"
symbolic = "12.16.3"
symbolicator-crash = { path = "crates/symbolicator-crash" }
symbolicator-js = { path = "crates/symbolicator-js" }
symbolicator-native = { path = "crates/symbolicator-native" }
Expand Down
2 changes: 1 addition & 1 deletion crates/symbolicator-native/src/symbolication/process_minidump.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ struct LookupKey {

impl LookupKey {
/// Creates a new lookup key for the given [`Module`].
fn new(module: &(dyn Module)) -> Self {
fn new(module: &dyn Module) -> Self {
Self {
base_addr: module.base_address(),
size: module.size(),
Expand Down
6 changes: 5 additions & 1 deletion crates/symbolicator-service/src/caches/versions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ static_assert!(symbolic::cfi::CFICACHE_LATEST_VERSION == 2);

/// SymCache, with the following versions:
///
/// - `11`: Fixes symcache generations for DWARF files with unusual tombstone addresses (<https://github.com/getsentry/symbolic/pull/937>)
///
/// - `10`: Fixes symcache generation for functions with no lines (<https://github.com/getsentry/symbolic/pull/930>)
///
/// - `9`: Fixes symcache generation from symbol tables (<https://github.com/getsentry/symbolic/pull/915>)
Expand Down Expand Up @@ -139,8 +141,9 @@ static_assert!(symbolic::cfi::CFICACHE_LATEST_VERSION == 2);
///
/// - `0`: Initial version.
pub const SYMCACHE_VERSIONS: CacheVersions = CacheVersions {
current: CacheVersion::new(10, CachePathFormat::V2),
current: CacheVersion::new(11, CachePathFormat::V2),
fallbacks: &[
CacheVersion::new(10, CachePathFormat::V2),
CacheVersion::new(9, CachePathFormat::V2),
CacheVersion::new(8, CachePathFormat::V2),
CacheVersion::new(7, CachePathFormat::V1),
Expand All @@ -156,6 +159,7 @@ pub const SYMCACHE_VERSIONS: CacheVersions = CacheVersions {
CacheVersion::new(7, CachePathFormat::V1),
CacheVersion::new(8, CachePathFormat::V2),
CacheVersion::new(9, CachePathFormat::V2),
CacheVersion::new(10, CachePathFormat::V2),
],
};
static_assert!(symbolic::symcache::SYMCACHE_VERSION == 8);
Expand Down
Loading