Removed deprecated SearchStrategies (PHP and LineNumber)#114
Open
Removed deprecated SearchStrategies (PHP and LineNumber)#114
Conversation
Contributor
|
YES! :) |
Owner
Author
|
Ha yes, forgot about this one in the message... |
gnugat
changed the title
Owner
Author
|
I'm a bit disappointed on the removed LoC number (355), I thought it would be much more :( |
Contributor
|
How many LoC is there currently? Insight said ~900, but not sure if you count LoC the same way... |
Owner
Author
|
I used the last two Insight analysis to count the LoC removed ;) . |
Contributor
There was a problem hiding this comment.
what about: "Locked EditorFactory" ?
Owner
Author
There was a problem hiding this comment.
I'd rather keep added/removed/fixed as main action description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for the big step?