Skip to content

Removed deprecated SearchStrategies (PHP and LineNumber) #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnugat wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed deprecated SearchStrategies (PHP and LineNumber) #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c08c589
Removed PHPToken deprecated features
Jan 10, 2015
3e06c47
Updated README
Jan 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changes between versions

## 2.0.0: Diet

* added lock to StringUtil
* added lock to EditorBuilder
* added lock to EditorFactory
Copy link
Copy Markdown
Contributor

@wouterj wouterj Jan 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about: "Locked EditorFactory" ?

Copy link
Copy Markdown
Owner Author

@gnugat gnugat Jan 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep added/removed/fixed as main action description

* removed deprecated features
Copy link
Copy Markdown
Contributor

@wouterj wouterj Jan 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add "(see the UPGRADE file for more information)"

Copy link
Copy Markdown
Owner Author

@gnugat gnugat Jan 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite right, I should also add a BC-break warning, even if the change of the MAJOR number is a big hint.


## 1.7.0: Brace yourselves, v2 is coming

* added documentation to upgrade to 2.0
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ editor-like object.

Use [Composer](http://getcomposer.org/) to install Redaktilo in your projects:

composer require "gnugat/redaktilo:~1.0"
composer require "gnugat/redaktilo:~2.0"

Redaktilo provides an `Editor` class which can be instanciated using
`EditorFactory`:
Expand Down
54 changes: 0 additions & 54 deletions src/Gnugat/Redaktilo/Search/LineNumberSearchStrategy.php
View file
Open in desktop

This file was deleted.

99 changes: 0 additions & 99 deletions src/Gnugat/Redaktilo/Search/Php/Token.php
View file
Open in desktop

This file was deleted.

146 changes: 0 additions & 146 deletions src/Gnugat/Redaktilo/Search/Php/TokenBuilder.php
View file
Open in desktop

This file was deleted.

Loading