chore(deps): update github.com/urfave/cli to 3.8.0#2726
chore(deps): update github.com/urfave/cli to 3.8.0#2726cuixq wants to merge 6 commits intogoogle:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
==========================================
- Coverage 79.77% 79.72% -0.05%
==========================================
Files 117 117
Lines 8016 8016
==========================================
- Hits 6395 6391 -4
- Misses 1246 1248 +2
- Partials 375 377 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| tests := []testcmd.Case{ | ||
| { | ||
| Name: "empty_plugins_flag_does_nothing", | ||
| Name: "empty_plugins_flag_does_default", |
There was a problem hiding this comment.
I don't think this is correct - the value being empty should not cause it to fallback to the default
what I would expect to happen is plugins ends up with an empty string, which we should consider an error
There was a problem hiding this comment.
There's a separate test with --no-default that does what you describe, and stays that way.
|
relating to my inline comment, could you check if this changes what happens with overall this change has some weird potential implications, so I think we should dig a bit deeper to confirm what the actual result is |
|
I'm not sure that's what happens though? An empty plugins string with out |
|
Pushed similar changes to #2674 directly. |
Unblocks #2674
For
github.com/urfave/cli/v3version 3.8.0, it seems an empty flag is no longer treated as an error but instead an empty flag will be set, see urfave/cli#2297.Thus this PR updated the expected exit codes and error messages for test cases involving empty flags.