Skip to content

chore(deps): update github.com/urfave/cli to 3.8.0 #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuixq wants to merge 6 commits into
base: main
Choose a base branch
from
+10 −13
Open

chore(deps): update github.com/urfave/cli to 3.8.0 #2726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02cf602
update github.com/urfave/cli to 3.8.0
cuixq Apr 16, 2026
2621d76
Merge branch 'main' into cli
cuixq Apr 16, 2026
21021af
snapshot
cuixq Apr 16, 2026
b30fb8d
snapshot
cuixq Apr 16, 2026
033ccda
snapshot
cuixq Apr 16, 2026
8a31a0b
snapshot
cuixq Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions cmd/osv-scanner/scan/source/__snapshots__/command_test.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2683,14 +2683,13 @@ Total 22 packages affected by 169 known vulnerabilities (18 Critical, 71 High, 5

---

[TestCommand_ExplicitExtractors_WithDefaults/empty_plugins_flag_does_nothing - 1]
[TestCommand_ExplicitExtractors_WithDefaults/empty_plugins_flag_does_default - 1]
Warning: plugin transitivedependency/pomxml can be risky when run on untrusted artifacts. Please ensure you trust the source code and artifacts before proceeding.

---

[TestCommand_ExplicitExtractors_WithDefaults/empty_plugins_flag_does_nothing - 2]
Incorrect Usage: flag needs an argument: --experimental-plugins=

flag needs an argument: --experimental-plugins=
[TestCommand_ExplicitExtractors_WithDefaults/empty_plugins_flag_does_default - 2]
No package sources found, --help for usage information.

---

Expand Down Expand Up @@ -2853,9 +2852,7 @@ could not determine extractor, requested package-lock.json
---

[TestCommand_ExplicitExtractors_WithoutDefaults/empty_plugins_flag_does_nothing - 2]
Incorrect Usage: flag needs an argument: --experimental-plugins=

flag needs an argument: --experimental-plugins=
at least one extractor must be enabled

---

Expand Down
4 changes: 2 additions & 2 deletions cmd/osv-scanner/scan/source/command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,9 +489,9 @@ func TestCommand_ExplicitExtractors_WithDefaults(t *testing.T) {

tests := []testcmd.Case{
{
Name: "empty_plugins_flag_does_nothing",
Name: "empty_plugins_flag_does_default",
Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct - the value being empty should not cause it to fallback to the default

what I would expect to happen is plugins ends up with an empty string, which we should consider an error

Copy link
Copy Markdown
Collaborator

@another-rex another-rex Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a separate test with --no-default that does what you describe, and stays that way.

Args: []string{"", "source", "--experimental-plugins="},
Exit: 127,
Exit: 128,
},
{
Name: "extractors_cancelled_out_specified_individually",
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ require (
github.com/tidwall/gjson v1.18.0
github.com/tidwall/pretty v1.2.1
github.com/tidwall/sjson v1.2.5
github.com/urfave/cli/v3 v3.7.0
github.com/urfave/cli/v3 v3.8.0
go.yaml.in/yaml/v4 v4.0.0-rc.4
golang.org/x/sync v0.20.0
golang.org/x/term v0.40.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,8 +488,8 @@ github.com/tonistiigi/go-csvvalue v0.0.0-20240814133006-030d3b2625d0 h1:2f304B10
github.com/tonistiigi/go-csvvalue v0.0.0-20240814133006-030d3b2625d0/go.mod h1:278M4p8WsNh3n4a1eqiFcV2FGk7wE5fwUpUom9mK9lE=
github.com/ulikunitz/xz v0.5.15 h1:9DNdB5s+SgV3bQ2ApL10xRc35ck0DuIX/isZvIk+ubY=
github.com/ulikunitz/xz v0.5.15/go.mod h1:nbz6k7qbPmH4IRqmfOplQw/tblSgqTqBwxkY0oWt/14=
github.com/urfave/cli/v3 v3.7.0 h1:AGSnbUyjtLiM+WJUb4dzXKldl/gL+F8OwmRDtVr6g2U=
github.com/urfave/cli/v3 v3.7.0/go.mod h1:ysVLtOEmg2tOy6PknnYVhDoouyC/6N42TMeoMzskhso=
github.com/urfave/cli/v3 v3.8.0 h1:XqKPrm0q4P0q5JpoclYoCAv0/MIvH/jZ2umzuf8pNTI=
github.com/urfave/cli/v3 v3.8.0/go.mod h1:ysVLtOEmg2tOy6PknnYVhDoouyC/6N42TMeoMzskhso=
github.com/vbatts/tar-split v0.12.1 h1:CqKoORW7BUWBe7UL/iqTVvkTBOF8UvOMKOIZykxnnbo=
github.com/vbatts/tar-split v0.12.1/go.mod h1:eF6B6i6ftWQcDqEn3/iGFRFRo8cBIMSJVOpnNdfTMFA=
github.com/xanzy/ssh-agent v0.3.3 h1:+/15pJfg/RsTxqYcX6fHqOXZwwMP+2VyYWJeWM2qQFM=
Expand Down
Loading