Skip to content

chore: Fix flaky testCreateAndUpdateTableWithPolicyTags test #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lqiu96 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Fix flaky testCreateAndUpdateTableWithPolicyTags test #4122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2082,8 +2082,12 @@ void testCreateAndUpdateTableWithPolicyTags() throws IOException {
.setParent(String.format("projects/%s/locations/%s", PROJECT_ID, "us"))
.setTaxonomy(
Taxonomy.newBuilder()
// DisplayName must be unique across org
.setDisplayName(String.format("testing taxonomy %s", Instant.now().getNano()))
// DisplayName must be unique across org. Use UUID rather than time to ensure
// no collisions
// from parallel test invocations
.setDisplayName(
String.format(
"testing taxonomy %s", UUID.randomUUID().toString().substring(0, 8)))
Comment on lines +2088 to +2090
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While using a UUID is a great improvement for uniqueness over Instant.now().getNano(), truncating it to 8 characters reduces its entropy and still leaves a small chance of collision, which could lead to test flakiness in the future. To ensure uniqueness across the organization as the comment suggests, it would be more robust to use the full UUID. If there is a length limit for DisplayName, it would be helpful to document that with a comment.

Additionally, for simple string concatenation, using the + operator is often more readable and can be more efficient than String.format.

                      .setDisplayName("testing taxonomy " + UUID.randomUUID().toString())

.setDescription("taxonomy created for integration tests")
.addActivatedPolicyTypes(PolicyType.FINE_GRAINED_ACCESS_CONTROL)
.build())
Expand Down
Loading