Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Change value sent for 'None of the above' option for conditions#733

Closed
SamJamCul wants to merge 1 commit intomainfrom
fix-none-of-the-above-value-condition-error
Closed

Change value sent for 'None of the above' option for conditions#733
SamJamCul wants to merge 1 commit intomainfrom
fix-none-of-the-above-value-condition-error

Conversation

@SamJamCul
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

https://trello.com/c/2H6cVned/2228-routes-based-on-none-of-the-above-answers-do-not-work

This reconciles a bug which we've encountered in forms runner - where we've been saving the answer value for optional selection questions as none_of_the_above, which will not be sucessfully compared with the forms runner's value of None of the above.

The change in the API is to make sure that our answer value doesn't exist error is now looking for a value of None of the above when it's an optional question, rather than none_of_the_above.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@SamJamCul SamJamCul force-pushed the fix-none-of-the-above-value-condition-error branch from 4ac75b0 to ffed912 Compare April 17, 2025 14:07
@SamJamCul SamJamCul changed the title fix-none-of-the-above-value-condition-error Change value sent for 'None of the above' option for conditions Apr 17, 2025
@SamJamCul SamJamCul force-pushed the fix-none-of-the-above-value-condition-error branch from ffed912 to 12b3ef2 Compare April 17, 2025 14:27
@sonarqubecloud
Copy link
Copy Markdown

@SamJamCul SamJamCul closed this Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants