fix(auth): write version field in credentials.json for grounds-push compat#16
Merged
fix(auth): write version field in credentials.json for grounds-push compat#16
Conversation
…ompat The Gradle plugin (grounds-push CredentialResolver) requires a 'version: 1' field but the CLI never wrote one, causing 'grounds push' to fail with: Failed to parse credentials file ... Field 'version' is required for type with serial name 'gg.grounds.push.client.CredentialsFile' Fix: - Add Version field to Credentials struct, always 1 on Marshal - ParseCredentials silently upgrades legacy (version=0) files to v1; they get re-written with the correct version on next refresh/login Cross-repo contract: must stay in lockstep with grounds-push plugin/src/main/kotlin/gg/grounds/push/client/CredentialResolver.kt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`grounds push` was failing for users with credentials.json files written by the CLI:
```
Root cause: The Gradle plugin's `CredentialResolver` (grounds-push) requires `version: 1`, but the CLI's `Credentials` struct never had a `version` field — schemas drifted because both were created in single-shot commits and never cross-synced.
Fix
Test plan
Cross-repo contract: must stay in lockstep with `grounds-push` `plugin/src/main/kotlin/gg/grounds/push/client/CredentialResolver.kt`. Both files now reference each other in their doc comments.
🤖 Generated with Claude Code