Conversation
Surfaced live: \`grounds login\` failed with
device endpoint 400: {"error":"invalid_request",
"error_description":"Missing parameter: code_challenge_method"}
Recent Keycloak versions enforce PKCE on the device-authorization
endpoint, but our DeviceClient was sending only client_id + scope.
Adds RFC 7636 PKCE:
- StartDevice generates a 256-bit URL-safe random verifier and the
matching SHA-256 challenge, sends \`code_challenge\` +
\`code_challenge_method=S256\` to /auth/device, and returns the
verifier on the response struct.
- PollToken takes the verifier as a new positional arg and forwards
it as \`code_verifier\` on each token-endpoint call so Keycloak
can validate the challenge bound to the device_code at request
time.
- login.go threads the verifier through.
Tests assert the new fields are sent on both endpoints.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced live — Keycloak rejects device flow without code_challenge_method now.