Conversation
lusu007
force-pushed
the
feat/perm-protos
branch
from
ca4cb47 to
b177ea9
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a new permission module to the gRPC contracts library, providing Protocol Buffers definitions for managing player permissions and groups. The module follows the same structure and conventions as the existing player and status modules.
Changes:
- Added new "permission" module with proto definitions for permissions management
- Created two service interfaces: PermissionsService (plugin-facing) and PermissionsAdminService (admin-facing)
- Updated build configuration to include the new module in the project
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle.kts | Added "permission" to included modules |
| release-please-config.json | Registered permission package for release management |
| .release-please-manifest.json | Set initial version 0.0.1 for permission module |
| permission/build.gradle.kts | Created build configuration matching existing modules |
| permission/README.md | Added module documentation |
| permission/src/main/proto/permissions.proto | Defined common messages, enums, and request/reply types |
| permission/src/main/proto/permissions_plugin.proto | Defined plugin-facing PermissionsService with GetPlayerPermissions and CheckPlayerPermission RPCs |
| permission/src/main/proto/permissions_admin.proto | Defined admin-facing PermissionsAdminService with group and permission management RPCs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lusu007
force-pushed
the
feat/perm-protos
branch
from
d39bb3e to
5fd98e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Type of Change
Related Issues
None
Testing
Checklist