feat: NOTES.txt + ci (lint + snapshot diff)#7
Merged
Conversation
NOTES.txt — post-install hints: hostname pattern, kubectl verify commands, agones config summary, log-tail command. Tailored to whether defaultFleet is enabled. CI workflow (.github/workflows/ci.yml): - helm lint (with cluster.name=test override) - helm template against three values presets, diffed against committed snapshots in tests/snapshots/ - Drift fails the build with a clear regenerate command Snapshots seeded: - default.yaml — full chart with defaults - no-default-fleet.yaml — defaultFleet.enabled=false - custom-image.yaml — image.tag override Spec: grounds-platform/docs/specs/2026-04-26-platform-vcluster-template.md (T7+T8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
templates/NOTES.txt— post-install hints surfacing hostname pattern, verify commands, agones config summary.github/workflows/ci.yml— helm lint + render against 3 values presets and diff against committed snapshotstests/snapshots/{default,no-default-fleet,custom-image}.yaml— seeded baselinesDrift fails CI with a clear regenerate command.
Test plan
Plan: grounds-platform/docs/plans/2026-04-26-platform-vcluster-template.md (T7+T8)