Skip to content

feat(paper): stay inert when no Agones SDK sidecar is present #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hbrombeer merged 1 commit into from
May 6, 2026
Merged

feat(paper): stay inert when no Agones SDK sidecar is present #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions paper/src/main/kotlin/gg/grounds/GroundsPluginAgones.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,27 @@ class GroundsPluginAgones : JavaPlugin() {
private lateinit var fallbackTask: BukkitTask

override fun onEnable() {
// The Agones SDK sidecar is only injected by the cluster's
// mutating webhook into pods that the controller has wrapped
// in a GameServer / Fleet. A plain plugin-paper Deployment
// (the default for non-gamemode workloads on Grounds) has no
// sidecar — the plugin's calls to localhost:9358 then loop on
// SocketException + log SEVERE every 10s, which is loud noise
// for an inert feature.
//
// The Agones webhook always sets `AGONES_SDK_HTTP_PORT` (and
// its grpc twin) on the GameServer container's env. Use that
// as the activation gate: present → real init; absent → log
// once and stay quiet.
val sidecarPort = System.getenv("AGONES_SDK_HTTP_PORT")
if (sidecarPort.isNullOrBlank()) {
logger.info(
"Skipped Agones plugin (reason=no_sidecar, " +
"AGONES_SDK_HTTP_PORT_unset); pod is not a GameServer"
)
return
}

val agonesHelper = createAgonesHelper()
setGameServerState(agonesHelper)

Expand Down