-
-
Notifications
You must be signed in to change notification settings - Fork 406
Capture output of eval
plugin and some girls scout changes
#4726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
199c13f
to
6d59fcd
Compare
fabcd5e
to
11a0f3f
Compare
eval
plugin and some girls scout changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a proper test in hls-eval-plugin
, but otherwise looks good to me, thank you for the clean up! Feel free to merge once you've added a test :)
Variable not in scope: cls :: t0 -> t | ||
Data constructor not in scope: C | ||
WAS Variable not in scope: cls :: t0 -> t | ||
WAS Data constructor not in scope: C | ||
NOW Illegal term-level use of the class `C' | ||
NOW defined at <interactive>:1:2 | ||
NOW In the first argument of `cls', namely `C' | ||
NOW In the expression: cls C | ||
NOW In an equation for `it_a5Zks': it_a5Zks = cls C | ||
NOW Variable not in scope: cls :: t0_a5ZlS[tau:1] -> t1_a5ZlU[tau:1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly weird, probably needs to be fixed one way or another?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize the eval
plugin changed some other results. Thanks for picking that up. I will investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed those WAS
NOW
errors, one question though:
Does the plugin also evaluate all actions in the same comment block in your case?
If I evaluate one action in this comment block, all of them get evaluated and a lot of WAS NOW messages get added. Some of them are wrong. I am not sure if this PR added this discrepancy, or if the problem was already there before. I will check.
5ade953
to
5ef2000
Compare
This PR contains some girl-scout changes as well as changes to how the
eval
plugin treatsstdout
andstderr
.Eval plugin
We now capture output to
stdout
andstderr
induced as a possible side effect by the statement being evaluated. This is fragile because the output may be scrambled in a concurrent setting when HLS is writing to one of these file handles from a different thread.Fixes #1977, most likely also #4390 (although this is debatable, we could do something more sophisticated).
Girl scout changes
eval
plugin in-source documentation