ETT-1148 Resource sharing users should get access to items that are deposited but not reported as held #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eposited but not reported as held - Add `Access::Holdings` utility routine to extract "held" value based on both `currently_held_count` and `deposited` - Add tests with manipulated versions of the expected currently-held response from mocked Holdings API - Add `deposited` fields to the mock holdings used in Playwright tests
moseshll
changed the title
aelkiss
approved these changes
Dec 1, 2025
Member
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
All makes sense to me and is as expected.
We should test on dev-N with the holdings API as it is -- I think this should be safe to deploy even in the absence of a deposited value from the holdings API, since it will default to 0 (https://github.com/hathitrust/babel/pull/171/files#diff-5be72f58ed64a38d91e23f4de4a169e268bae840681f53d60870b8acec524d90R176), but it's definitely worth double checking that.
Contributor
Author
|
I have checked this branch against dev-2 and did not encounter any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETT-1148 Resource sharing users should get access to items that are deposited but not reported as held
Access::Holdingsutility routine to extract "held" value based on bothcurrently_held_countanddepositeddepositedfields to the mock holdings used in Playwright testsETT-743 disable brittle auth.t test