fix(sdk): add tsconfig to types & clean repo (#1)#2
Open
maclorlando wants to merge 1 commit intoheirlabs:mainfrom
Open
fix(sdk): add tsconfig to types & clean repo (#1)#2maclorlando wants to merge 1 commit intoheirlabs:mainfrom
maclorlando wants to merge 1 commit intoheirlabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a failing test and cleans up the repository.
Changes
✅ Added
tsconfig.jsontotypes/to allowtsc --noEmitto pass.✅ Added
/node_modules/to.gitignore.✅ Removed
node_modules/from the repository.Before
npm testfailed in@defai/element-types.node_modules/folder..gitignoremissing common entries.After
npm install,npm run build, andnpm testall succeed..gitignoreproperly excludesnode_modules/.Notes
node_modules/, which inflates the diff. Actual functional changes are limited to.gitignoreandtypes/tsconfig.json.Closes #1