Feature: enable multiple interfaces in one sketch#141
Merged
hideakitai merged 3 commits intomainfrom Oct 16, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables multiple interfaces to be used in one sketch by refactoring the Artnet library to use interface-specific class names and removing the generic Artnet.h header that prevented multiple interfaces.
- Removes generic
Artnet.hheader that caused conflicts when using multiple interfaces - Updates all interface-specific headers to use prefixed class names (e.g.,
ArtnetWiFi,ArtnetEther) - Updates all example files to use the new interface-specific class names
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Artnet.h | Completely removed to eliminate interface conflicts |
| ArtnetWiFi.h | No changes shown in diff |
| ArtnetEther.h | Updated class names from generic to ArtnetEther prefix |
| ArtnetEtherENC.h | Updated class names from generic to ArtnetEtherENC prefix |
| ArtnetETH.h | Updated class names from generic to ArtnetETH prefix |
| ArtnetNativeEther.h | Updated class names from generic to ArtnetNativeEther prefix |
| examples/WiFi/* | Removed outdated comments and updated documentation |
| examples/Ethernet/* | Removed outdated comments and updated class names to ArtnetEther variants |
| examples/EthernetENC/* | Updated class names to ArtnetEtherENC variants |
| examples/ETH/* | Updated class names to ArtnetETH variants |
| README.md | Updated documentation to reflect new API and interface-specific usage |
| Artnet/Receiver.h | Changed flush() to clear() method call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ed7c485 to
03e9506
Compare
17a0449 to
03e9506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: