Skip to content

Refactor: network related abstraction#142

Merged
hideakitai merged 5 commits intomainfrom
refactor/network-related-abstraction
Oct 16, 2025
Merged

Refactor: network related abstraction#142
hideakitai merged 5 commits intomainfrom
refactor/network-related-abstraction

Conversation

@hideakitai
Copy link
Owner

@hideakitai hideakitai self-assigned this Oct 16, 2025
Base automatically changed from feature/enable-multiple-interfaces-in-one-sketch to main October 16, 2025 18:04
@hideakitai hideakitai requested a review from Copilot October 16, 2025 18:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors network-related abstraction by consolidating network interface implementations across different Ethernet and WiFi libraries. The refactoring replaces preprocessor-based conditional compilation with template-based trait specializations to provide a more unified and type-safe network abstraction layer.

  • Introduces new ReceiverTraits.h with template traits for network operations
  • Consolidates network-specific implementations from individual files into centralized trait specializations
  • Removes preprocessor defines (ARTNET_ENABLE_WIFI, ARTNET_ENABLE_ETHER, etc.) in favor of template-based approach

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
examples/EthernetENC/send_receive/send_receive.ino Removes blank line for formatting
ArtnetWiFi.h Adds WiFi-specific trait implementations and removes conditional compilation
ArtnetNativeEther.h Adds NativeEthernet trait implementations and removes preprocessor defines
ArtnetEtherENC.h Adds EthernetENC trait implementations and removes preprocessor defines
ArtnetEther.h Adds standard Ethernet trait implementations and removes preprocessor defines
ArtnetETH.h Adds ESP32 ETH trait implementations and removes preprocessor defines
Artnet/Sender.h Updates to use templated network ready check
Artnet/ReceiverTraits.h New file defining network abstraction traits
Artnet/Receiver.h Refactors to use trait-based network functions and removes inline implementations
Artnet/Common.h Removes WiFi-specific network ready function
.github/workflows/build.yml Adds commented entries for Raspberry Pi Pico 2W support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hideakitai hideakitai force-pushed the refactor/network-related-abstraction branch from 8dd1ea8 to eee3ce6 Compare October 16, 2025 18:19
@hideakitai hideakitai requested a review from Copilot October 16, 2025 18:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hideakitai hideakitai merged commit f82bf08 into main Oct 16, 2025
25 checks passed
@hideakitai hideakitai deleted the refactor/network-related-abstraction branch October 16, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants