Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the wimse_domain from zeroid.dev to highflame.ai in both config.go and zeroid.yaml. The review feedback highlights that the domain change is incomplete, as related fields like token.issuer and token.base_url still reference the old domain, which could lead to inconsistencies in SPIFFE identity issuance and OIDC federation.
|
|
||
| // WIMSE | ||
| "wimse_domain": "zeroid.dev", | ||
| "wimse_domain": "highflame.ai", |
There was a problem hiding this comment.
The trust domain is being renamed to highflame.ai, but the default token.issuer and token.base_url (lines 184-185) still reference zeroid.dev. To ensure consistency in SPIFFE identity issuance and discovery, these values should likely be updated to match the new domain as well.
| max_ttl: 7776000 # 90 days | ||
|
|
||
| wimse_domain: "zeroid.dev" | ||
| wimse_domain: "highflame.ai" |
There was a problem hiding this comment.
The wimse_domain has been updated to highflame.ai, but the token.issuer on line 28 still points to https://auth.zeroid.dev. These should be kept in sync to avoid potential issues with SPIFFE ID validation and OIDC federation where the trust domain and issuer are expected to be aligned.
1 participant
Summary
Type of change
Testing
Impact / Risks
📸 Screenshots / Logs (if applicable)