Skip to content

fix: Spiffe URI trust domain rename #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saucam wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: Spiffe URI trust domain rename #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ func loadDefaults(k *koanf.Koanf) error {
"token.max_ttl": 7776000, // 90 days

// WIMSE
"wimse_domain": "zeroid.dev",
"wimse_domain": "highflame.ai",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The trust domain is being renamed to highflame.ai, but the default token.issuer and token.base_url (lines 184-185) still reference zeroid.dev. To ensure consistency in SPIFFE identity issuance and discovery, these values should likely be updated to match the new domain as well.


// Telemetry
"telemetry.enabled": false,
Expand Down
2 changes: 1 addition & 1 deletion zeroid.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ token:
default_ttl: 3600
max_ttl: 7776000 # 90 days

wimse_domain: "zeroid.dev"
wimse_domain: "highflame.ai"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The wimse_domain has been updated to highflame.ai, but the token.issuer on line 28 still points to https://auth.zeroid.dev. These should be kept in sync to avoid potential issues with SPIFFE ID validation and OIDC federation where the trust domain and issuer are expected to be aligned.


# Admin routes (/api/v1/*) have no built-in auth.
# In production, protect them at the network layer (reverse proxy, VPN, firewall)
Expand Down