Skip to content

Add current team template #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
axdanbol merged 80 commits into from
Jan 23, 2026
Merged

Add current team template #1989

axdanbol merged 80 commits into from
Jan 23, 2026

Conversation

@prashantchanne12
Copy link
Contributor

@prashantchanne12 prashantchanne12 commented Nov 28, 2025

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Nov 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 33d6a00

Command Status Duration Result
nx affected --targets=lint,test,compodoc --conf... ✅ Succeeded 45s View ↗
nx affected --target=build,build-webcomponent,b... ✅ Succeeded 1m 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-23 22:40:37 UTC

@prashantchanne12 prashantchanne12 linked an issue Nov 28, 2025 that may be closed by this pull request
Add People page - Current team #1856
Open
1 task
@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

🚀 Preview Deploy Report

✅ Successfully deployed preview here

@prashantchanne12 prashantchanne12 self-assigned this Dec 2, 2025
@axdanbol axdanbol marked this pull request as ready for review December 2, 2025 20:07
axdanbol and others added 18 commits December 2, 2025 15:07
axdanbol and others added 20 commits January 16, 2026 17:55
@axdanbol
build(global): Update ngxtension dependency
5a70098
@axdanbol
feat(app:cns-website): Connect filters to query params
a57f927
@axdanbol
fix(app:cns-website): Fix query param parsing of option lists
8f5f091
@axdanbol
Merge branch 'add-current-team-template' of https://github.com/hubmap…
25c8b6c 
…consortium/hra-ui into add-current-team-template
@axdanbol
feat(app:cns-website): Update search to ignore diacritics
0f0268a
@prashantchanne12
removing button toggle border
019c56a
@prashantchanne12
removing unecessary styles
f3ca871
@prashantchanne12
adding documentation
e239f58
@axdanbol
fix(app:cns-website): Fix group by sorting for start year
17f2307
@axdanbol
Merge branch 'add-current-team-template' of https://github.com/hubmap…
702db10 
…consortium/hra-ui into add-current-team-template
@axdanbol
refactor(app:cns-website): Update total count to be num people in the…
bcd95b2 
… selected team
@axdanbol
feat(app:cns-website): Add root store for managing the sidebar
dca681d
@axdanbol
refactor(app:cns-website): Simplified team page styles & connected si…
9a62794 
…debar to state
@axdanbol
docs(app:cns-website): Add missing code documentation
10e0799
@axdanbol
fix(app:cns-website): Minor sidebar bug fix
b8a09eb
@axdanbol
refactor(global): 🚨 Fix lint errors
466b090
@axdanbol
refactor(app:cns-website): Tweak styling & aria
beccada
@prashantchanne12
added tests for current-team component
9055a06
@prashantchanne12
Merge branch 'add-current-team-template' of https://github.com/hubmap…
5fe5e0d 
…consortium/hra-ui into add-current-team-template
@axdanbol
test(app:cns-website): ✅ Add test for sidebar state
d8613cf
@LibbyUX
Copy link
Contributor

LibbyUX commented Jan 23, 2026

Quick review with Daniel

  • Grouping header spacing
  • Search and counter shouldn't wrap on smaller breakpoints
  • Nice to have: Hide roles with no entries

@LibbyUX
Copy link
Contributor

LibbyUX commented Jan 23, 2026

More review changes:

  • Always push footer to bottom
  • Check alignment of mail footer button on different browsers

@axdanbol axdanbol merged commit e0b4f62 into cns-website Jan 23, 2026
1 check passed
@axdanbol axdanbol deleted the add-current-team-template branch January 23, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bherr2 bherr2 bherr2 left review comments

@axdanbol axdanbol axdanbol approved these changes

Assignees

@prashantchanne12 prashantchanne12

Labels

cns-website ♻️ Design system component needed for cns.iu.edu implementation and later iterations of the HRA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add People page - Current team

5 participants

@prashantchanne12 @LibbyUX @axdanbol @bherr2