Conversation
a113463 to
4f2c2c5
Compare
|
I have also updated https://github.com/huboard/huboard/wiki/Local-Development with more correct/complete instructions (even beyond what @discorick reviewed mid-day): https://github.com/huboard/huboard/wiki/Local-Development/_compare/d8b6c62e89b92c029251c6c1c7913609857caf4b...52ab3eeee097c72688b1ad6b5e4d26612c7c3156 |
| "build": "ember build", | ||
| "test": "ember test", | ||
| "postinstall": "pwd && ../node_modules/.bin/bower install" | ||
| "postinstall": "node ../node_modules/bower/bin/bower install" |
There was a problem hiding this comment.
I wasn't aware that npm on windows and npm on unix differed in this convention.
This might not work for a heroku deployment
There was a problem hiding this comment.
It does, as far as I can tell: https://huboard-rails-pr-201.herokuapp.com/
|
Would appreciate some eyes one this next round of Local Dev updates based on some challenges getting another Windows machine up and running: https://github.com/huboard/huboard/wiki/Local-Development/_compare/52ab3eeee097c72688b1ad6b5e4d26612c7c3156...c8e5cb7b6328054ab0e1ed6518d8fca13e4dd353?short_path=459bc87#diff-459bc87850f2ab005ca4943e7253122c |
|
@dahlbyk were you planning on removing the app.json file from source control ? |
Have to commit it for Heroku per-PR deploy to work. I can revert it here and move to a separate PR for addressing #183 if you'd prefer. The last thing we need to figure out here is why we still end up with Bundler 1.11.2 after a gem uninstall --ignore-dependencies --executables --quiet bundler
gem install bundler --version 1.9.6 --no-ri --no-rdocIf I Finally, setting my bundler issues aside: why doesn't |
Alright, so within While So my current hack won't work. Any ideas? |
|
So it looks like |
|
@dahlbyk are you asking how to get bundler to install on provision ? |
ec26b35 to
35e6144
Compare
b001852 to
4dccbcf
Compare
4dccbcf to
e5682d3
Compare
|
Alright, I've moved the commits related to #183 over into #214 so we can focus on the Vagrant and Windows story. After #213, we're tentatively cool with Bundler > 1.10, so I've dropped my misguided attempts to downgrade to 1.9.6. This also commits the much-maligned
I was asking this, yes, but we can defer that discussion. |
|
I've deployed latest here to https://huboard-rails.herokuapp.com/ for a sanity check. |
provision.sh
Outdated
| @@ -0,0 +1,2 @@ | |||
| # Switch to /srv/huboard on login | |||
| echo "cd /srv/huboard" >> /home/vagrant/.bashrc | |||
There was a problem hiding this comment.
Lets pair together on moving this to puppet, its probably best to keep our provisioning unified.
|
As we move |
| exec { "echo 'cd /srv/huboard' >> .bashrc": | ||
| cwd => "/home/vagrant", | ||
| path => "/usr/bin:/usr/sbin:/bin", | ||
| unless => "grep -q '^cd /srv/huboard$' .bashrc" |
There was a problem hiding this comment.
Lets pair together on moving this to puppet, its probably best to keep our provisioning unified.
Better?
I tried a bunch of iterations along the lines of: diff --git a/puppet/manifests/base.pp b/puppet/manifests/base.pp
index 5fee4ee..4663669 100644
--- a/puppet/manifests/base.pp
+++ b/puppet/manifests/base.pp
@@ -13,6 +13,12 @@ package {
ruby_version => "2.2.1",
}
+ exec { 'bundle install':
+ cwd => "/home/vagrant",
+ path => "/usr/bin:/usr/sbin:/bin:/home/vagrant/.rbenv/bin:/home/vagrant/.rbenv/shims",
+ require => Class['ruby_install']
+ }
+
class { 'wkhtmltox':
ensure => 'present'
}I tried Here's the full Vagrant/Puppet debug log for |
|
Let's punt on adding bundler to this PR, and have a more general 'update puppet manifest' PR at a later date
|
Clean Vagrant+Windows Install
Here are some miscellaneous changes from getting Vagrant up and running on a clean Windows machine.
.gitattributesfor EOL consistencypwd(for debugging) frompostinstall(Windows doesn't like the&&)postinstallcallsbowerto be more Windows-friendly - @discorick can you confirmcd ember-app && npm installworks as expected if you remove their cache dirs?Puppetprovision.shfor extra provisiony stuff, starting with addingexecto addcd /srv/huboardto.bashrcForce downgrade bundler to 1.9.6.It feels like there should be a better way to do this, but I can't tell exactly where thebundlergem is being installed.@rauhryan, are you able to fill in background on why newer versions won't work?