Skip to content

Conversation

@Gero1999
Copy link
Contributor

Closes #473

Just worthy to mention that the unit tests we do for pk.calc function will never cover these cases. Maybe is worthy to consider doing at some point a test for pk.nca with a dataset that contains all columns and a for-loop checking all parameters independently.

@billdenney
Copy link
Member

I like this simple fix. Can you please add a test for it with pk.nca()?

@Gero1999 Gero1999 marked this pull request as draft November 7, 2025 17:03
@billdenney
Copy link
Member

When merged this will likely fix #376, too.

@Gero1999 Gero1999 changed the title Fix: fe not calculated if ae not included in intervals (#473) Fix: fe and clr not calculated if ae not included in intervals (#473) Nov 11, 2025
@Gero1999 Gero1999 marked this pull request as ready for review November 11, 2025 06:07
@Gero1999
Copy link
Contributor Author

@billdenney I implemented the test and detected a similar problem for clr parameters, so I fixed them. However, there are other parameters that cannot be run with pk.nca directly for other reasons. If needed, I think we can address them independently in another issue/PR

@billdenney billdenney merged commit 3b72ee4 into humanpred:main Dec 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: fe not calculated if ae not included in intervals

2 participants