feat: #106 Improve signIn error handling

[ianpaschal]

Summary by CodeRabbit

• Bug Fixes

  • Improved email validation in the sign-in form to require a valid email format.

• New Features

  • Enhanced error messages during sign-in, providing clearer feedback when authentication fails.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
combat-command	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 30, 2025 8:41pm

[coderabbitai]

Walkthrough

The sign-in form's email validation was updated to require a valid email format instead of just a non-empty string. Additionally, the authentication logic now translates backend errors into clearer, user-friendly messages using a new internal helper function, improving error feedback during sign-in attempts.

Changes

File(s)	Change Summary
src/pages/AuthPage/components/SignInForm/SignInForm.schema.ts	Enhanced email validation to require a valid email format instead of only a non-empty string.
src/services/auth/useSignIn.ts	Added internal helper to map authentication errors to user-friendly messages and updated error handling logic.

Poem

A bunny hopped on login ground,
Now emails must be real, not just around.
If sign-in fails, don’t fear or pout—
Friendlier messages will help you out!
With every hop, we clarify,
So users smile, and errors fly.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-30T20_43_24_270Z-debug-0.log

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/pages/AuthPage/components/SignInForm/SignInForm.schema.ts (1)

4-4: Update error message to match email format validation.

The validation correctly requires a proper email format, but the error message "Please enter your email." is misleading for format validation failures. Consider updating it to indicate the format requirement.

-  email: z.string().email('Please enter your email.').transform((val) => val.trim().toLowerCase()),
+  email: z.string().email('Please enter a valid email address.').transform((val) => val.trim().toLowerCase()),

src/services/auth/useSignIn.ts (1)

17-28: Consider improving error type safety and robustness.

The error mapping function is a good approach for user-friendly messaging. However, consider these improvements:

1. Type safety: Instead of any, consider defining a proper error type or using unknown with type guards.
2. Robustness: The string inclusion check could be more specific to avoid false positives.

-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-function mapConvexAuthError(error: any): string {
+function mapConvexAuthError(error: unknown): string {
+  if (typeof error !== 'object' || error === null) {
+    return 'An unexpected error occurred. Please try again.';
+  }
+  
+  const errorObj = error as { message?: string };
-  if (!error?.message) {
+  if (!errorObj.message || typeof errorObj.message !== 'string') {
     return 'An unexpected error occurred. Please try again.';
   }

-  if (error.message.includes('InvalidAccountId')) {
+  if (errorObj.message.includes('InvalidAccountId')) {
     return 'Your email or password is incorrect.';
   }

   return 'Sign-in failed. Please check your details and try again.';
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7839d89 and ea3dcfe.

📒 Files selected for processing (2)

• src/pages/AuthPage/components/SignInForm/SignInForm.schema.ts (1 hunks)
• src/services/auth/useSignIn.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/services/auth/useSignIn.ts (1)

src/components/ToastProvider/ToastProvider.store.ts (1)

• toast (29-50)

🔇 Additional comments (1)

src/services/auth/useSignIn.ts (1)

63-65: LGTM! Error handling integration looks good.

The integration of the error mapping function with the toast notification provides a better user experience by showing meaningful error messages instead of raw backend errors.